You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by "xingZhang (JIRA)" <ji...@apache.org> on 2017/11/23 07:10:00 UTC
[jira] [Resolved] (WEEX-96) Timer exposed on JSContext can not
clear and it has potential crash switching globalQueue
[ https://issues.apache.org/jira/browse/WEEX-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
xingZhang resolved WEEX-96.
---------------------------
Resolution: Fixed
Assignee: xingZhang (was: Adam Feng)
> Timer exposed on JSContext can not clear and it has potential crash switching globalQueue
> -----------------------------------------------------------------------------------------
>
> Key: WEEX-96
> URL: https://issues.apache.org/jira/browse/WEEX-96
> Project: Weex
> Issue Type: Bug
> Reporter: xingZhang
> Assignee: xingZhang
> Priority: Critical
>
> 1. timer can not be clear
> As the WXJSCoreBridge file in [line 544](https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L544) shows the code, the appId is a string , so it will never be cleared.
> 2. timer execute js function in global queue may have potential crash, it had better execution in current thread.
> WXJSCoreBridge https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L535
> 3. timerId will always be 1, not auto-increment as the count of timer increasing
> https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L513
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)