You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "Christopher K. St. John" <ck...@distributopia.com> on 2002/04/15 18:59:05 UTC

o.a.c.startup.EngineConfig doesn't do anything?

 I can't figure out what EngineConfig is for. It doesn't
appear to do anything at all. The docs say it "configures
the properties of the engine and the associated defined
contexts". But it doesn't.

 Craig? You and Pier are the only people to have touched
this, and Pier just re-indented.

 I know it seems trivial, but dead code (that's getting
maintained!) is evil. Especially when it's something as
confusing as Catalina startup code. The alternative is
that I'm wrong, and it is used for something. In that
case, the comments should be better. 

 I'm willing to either patch it out (should just be 
EngineRuleSet), or write some better comments, either
way.



-- 
Christopher St. John cks@distributopia.com
DistribuTopia http://www.distributopia.com

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: o.a.c.startup.EngineConfig doesn't do anything?

Posted by "Craig R. McClanahan" <cr...@apache.org>.
Originally, it was a placeholder for auto-config things that should be
done at startup of the Engine.  If there aren't any such things, it is
technically unused code -- but I would just comment out the adding of the
valve rather than removing the code, so people have a place to go later.

Craig

On Mon, 15 Apr 2002, Christopher K.  St.  John wrote:

> Date: Mon, 15 Apr 2002 09:59:05 -0700 (PDT)
> From: Christopher K.  St.  John <ck...@distributopia.com>
> Reply-To: Tomcat Developers List <to...@jakarta.apache.org>
> To: tomcat-dev@jakarta.apache.org
> Subject: o.a.c.startup.EngineConfig doesn't do anything?
>
>
>  I can't figure out what EngineConfig is for. It doesn't
> appear to do anything at all. The docs say it "configures
> the properties of the engine and the associated defined
> contexts". But it doesn't.
>
>  Craig? You and Pier are the only people to have touched
> this, and Pier just re-indented.
>
>  I know it seems trivial, but dead code (that's getting
> maintained!) is evil. Especially when it's something as
> confusing as Catalina startup code. The alternative is
> that I'm wrong, and it is used for something. In that
> case, the comments should be better.
>
>  I'm willing to either patch it out (should just be
> EngineRuleSet), or write some better comments, either
> way.
>
>
>
> --
> Christopher St. John cks@distributopia.com
> DistribuTopia http://www.distributopia.com
>
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>