You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/18 15:50:02 UTC
[GitHub] [flink] buptljy opened a new pull request #10622: [FLINK-14364]
[flink-formats] Add validation when format.allow-comments is used with
format.ignore-parse-errors in CsvValidator
buptljy opened a new pull request #10622: [FLINK-14364] [flink-formats] Add validation when format.allow-comments is used with format.ignore-parse-errors in CsvValidator
URL: https://github.com/apache/flink/pull/10622
## What is the purpose of the change
As described in [FLINK-14364](https://issues.apache.org/jira/browse/FLINK-14364), we can only use `format.allow-comments` when `format.ignore-parse-errors` is set. So we add a validation here to improve the usability.
## Brief change log
Add a new check in `CsvValidator`.
## Verifying this change
Unit testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10622: [FLINK-14364]
[flink-formats] Add validation when format.allow-comments is used with
format.ignore-parse-errors in CsvValidator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10622: [FLINK-14364] [flink-formats] Add validation when format.allow-comments is used with format.ignore-parse-errors in CsvValidator
URL: https://github.com/apache/flink/pull/10622#issuecomment-567106606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6292447ad822b83196409881704f987e5e033b32",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/141618814",
"triggerID" : "6292447ad822b83196409881704f987e5e033b32",
"triggerType" : "PUSH"
}, {
"hash" : "6292447ad822b83196409881704f987e5e033b32",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3740",
"triggerID" : "6292447ad822b83196409881704f987e5e033b32",
"triggerType" : "PUSH"
}, {
"hash" : "22f2430ce07337080834b0e1d8184a99f9e558df",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/141774903",
"triggerID" : "22f2430ce07337080834b0e1d8184a99f9e558df",
"triggerType" : "PUSH"
}, {
"hash" : "22f2430ce07337080834b0e1d8184a99f9e558df",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3774",
"triggerID" : "22f2430ce07337080834b0e1d8184a99f9e558df",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6292447ad822b83196409881704f987e5e033b32 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141618814) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3740)
* 22f2430ce07337080834b0e1d8184a99f9e558df Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141774903) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3774)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10622: [FLINK-14364]
[flink-formats] Add validation when format.allow-comments is used with
format.ignore-parse-errors in CsvValidator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10622: [FLINK-14364] [flink-formats] Add validation when format.allow-comments is used with format.ignore-parse-errors in CsvValidator
URL: https://github.com/apache/flink/pull/10622#issuecomment-567106606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6292447ad822b83196409881704f987e5e033b32",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/141618814",
"triggerID" : "6292447ad822b83196409881704f987e5e033b32",
"triggerType" : "PUSH"
}, {
"hash" : "6292447ad822b83196409881704f987e5e033b32",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3740",
"triggerID" : "6292447ad822b83196409881704f987e5e033b32",
"triggerType" : "PUSH"
}, {
"hash" : "22f2430ce07337080834b0e1d8184a99f9e558df",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/141774903",
"triggerID" : "22f2430ce07337080834b0e1d8184a99f9e558df",
"triggerType" : "PUSH"
}, {
"hash" : "22f2430ce07337080834b0e1d8184a99f9e558df",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3774",
"triggerID" : "22f2430ce07337080834b0e1d8184a99f9e558df",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6292447ad822b83196409881704f987e5e033b32 UNKNOWN
* 22f2430ce07337080834b0e1d8184a99f9e558df Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141774903) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3774)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10622: [FLINK-14364]
[flink-formats] Add validation when format.allow-comments is used with
format.ignore-parse-errors in CsvValidator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10622: [FLINK-14364] [flink-formats] Add validation when format.allow-comments is used with format.ignore-parse-errors in CsvValidator
URL: https://github.com/apache/flink/pull/10622#issuecomment-567106606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6292447ad822b83196409881704f987e5e033b32",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/141618814",
"triggerID" : "6292447ad822b83196409881704f987e5e033b32",
"triggerType" : "PUSH"
}, {
"hash" : "6292447ad822b83196409881704f987e5e033b32",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3740",
"triggerID" : "6292447ad822b83196409881704f987e5e033b32",
"triggerType" : "PUSH"
}, {
"hash" : "22f2430ce07337080834b0e1d8184a99f9e558df",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/141774903",
"triggerID" : "22f2430ce07337080834b0e1d8184a99f9e558df",
"triggerType" : "PUSH"
}, {
"hash" : "22f2430ce07337080834b0e1d8184a99f9e558df",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3774",
"triggerID" : "22f2430ce07337080834b0e1d8184a99f9e558df",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22f2430ce07337080834b0e1d8184a99f9e558df Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141774903) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3774)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services