You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kevingurney (via GitHub)" <gi...@apache.org> on 2023/09/20 16:37:29 UTC
[GitHub] [arrow] kevingurney opened a new pull request, #37808: GH-37805: [CI][MATLAB] Hard-code `release` to `R2023a` for `matlab-actions/setup-matlab` action in MATLAB CI workflows
kevingurney opened a new pull request, #37808:
URL: https://github.com/apache/arrow/pull/37808
### Rationale for this change
Due to a recent change to default to R2023b by default for the `[matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) action in GitHub Actions, the MATLAB CI workflows are failing.
Example failure logs:
https://github.com/apache/arrow/actions/runs/6250586979/job/16970596069?pr=37773#step:9:70
Our preferred solution to address this in the short term is to explicitly specify the [`release` parameter](https://github.com/matlab-actions/setup-matlab#set-up-matlab) to the `setup-matlab` action to be `R2023a`.
In the long term, we can work on figuring out why the build is failing on Windows with `R2023b`.
For reference - it appears that the `FindMatlab` CMake module only recently added R2023b to its list of recognized versions:
https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8804
### What changes are included in this PR?
1. Hard-coded MATLAB `release` to `R2023a` for the `[matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) action in the MATLAB CI workflows.
### Are these changes tested?
Yes.
1. [MATLAB CI workflows are passing on all platforms in `mathworks/arrow`](https://github.com/mathworks/arrow/actions/runs/6251345588).
### Are there any user-facing changes?
No.
This change only impacts the MATLAB CI workflows which were defaulting to `R2023a` by default in the past.
### Future Directions
1. Investigate why the [MATLAB CI workflows are failing on Windows when using MATLAB `R2023b`](https://github.com/apache/arrow/actions/runs/6250586979/job/16972019524?pr=37773#step:9:66).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37808: GH-37805: [CI][MATLAB] Hard-code `release` to `R2023a` for `matlab-actions/setup-matlab` action in MATLAB CI workflows
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37808:
URL: https://github.com/apache/arrow/pull/37808#issuecomment-1728690614
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit e068b7f845514637d3ffebd6e341b38439742a40.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/16987686969) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney merged pull request #37808: GH-37805: [CI][MATLAB] Hard-code `release` to `R2023a` for `matlab-actions/setup-matlab` action in MATLAB CI workflows
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney merged PR #37808:
URL: https://github.com/apache/arrow/pull/37808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney commented on pull request #37808: GH-37805: [CI][MATLAB] Hard-code `release` to `R2023a` for `matlab-actions/setup-matlab` action in MATLAB CI workflows
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #37808:
URL: https://github.com/apache/arrow/pull/37808#issuecomment-1728115811
CI failures are related to #37803.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney commented on pull request #37808: GH-37805: [CI][MATLAB] Hard-code `release` to `R2023a` for `matlab-actions/setup-matlab` action in MATLAB CI workflows
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #37808:
URL: https://github.com/apache/arrow/pull/37808#issuecomment-1728144708
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org