You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2023/07/08 01:24:28 UTC
[GitHub] [doris] yiguolei commented on a diff in pull request #21640: [refactor](planner) refactor automatically set instance_num
yiguolei commented on code in PR #21640:
URL: https://github.com/apache/doris/pull/21640#discussion_r1256716909
##########
fe/fe-core/src/main/java/org/apache/doris/system/Backend.java:
##########
@@ -519,6 +542,24 @@ public void updateDisks(Map<String, TDisk> backendDisks) {
}
}
+ public void updateCpuInfo(int cpuCores, int pipelineExecutorSize) {
+ boolean isChanged = false;
+
+ if (this.cpuCores != cpuCores) {
+ this.cpuCores = cpuCores;
+ isChanged = true;
+ }
+ if (this.pipelineExecutorSize != pipelineExecutorSize) {
+ this.pipelineExecutorSize = pipelineExecutorSize;
+ isChanged = true;
+ }
+ if (isChanged) {
+ LOG.info("add new cpu info. backendId: {}, cpucores: {}, pipelineExecutorSize: {}", id, cpuCores,
+ pipelineExecutorSize);
+ Env.getCurrentEnv().getEditLog().logBackendStateChange(this);
Review Comment:
不要在这加这个逻辑
##########
fe/fe-core/src/main/java/org/apache/doris/system/Backend.java:
##########
@@ -519,6 +542,24 @@ public void updateDisks(Map<String, TDisk> backendDisks) {
}
}
+ public void updateCpuInfo(int cpuCores, int pipelineExecutorSize) {
+ boolean isChanged = false;
+
+ if (this.cpuCores != cpuCores) {
+ this.cpuCores = cpuCores;
+ isChanged = true;
+ }
+ if (this.pipelineExecutorSize != pipelineExecutorSize) {
+ this.pipelineExecutorSize = pipelineExecutorSize;
+ isChanged = true;
+ }
+ if (isChanged) {
+ LOG.info("add new cpu info. backendId: {}, cpucores: {}, pipelineExecutorSize: {}", id, cpuCores,
+ pipelineExecutorSize);
+ Env.getCurrentEnv().getEditLog().logBackendStateChange(this);
Review Comment:
不要在这加这个逻辑
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org