You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/12 22:53:14 UTC
Review Request 55475: Added `Master::isRemovable(const TaskState&)`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55475/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-6619
https://issues.apache.org/jira/browse/MESOS-6619
Repository: mesos
Description
-------
This determines whether a task in the given state can safely be
discarded from the master's in-memory state. When a task becomes
removable, we move the task from the master's main task data structures
to a fixed-size cache (either the "unreachable" or "completed" task
list, as appropriate).
Diffs
-----
src/master/master.hpp 368ee1d5e97784fa54e0f141906405ee8f104317
src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040
Diff: https://reviews.apache.org/r/55475/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 55475: Added `Master::isRemovable(const
TaskState&)`.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55475/#review162734
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 21, 2017, 7:49 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55475/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2017, 7:49 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6619
> https://issues.apache.org/jira/browse/MESOS-6619
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This determines whether a task in the given state can safely be
> discarded from the master's in-memory state. When a task becomes
> removable, we move the task from the master's main task data structures
> to a fixed-size cache (either the "unreachable" or "completed" task
> list, as appropriate).
>
>
> Diffs
> -----
>
> src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b
> src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
>
> Diff: https://reviews.apache.org/r/55475/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 55475: Added `Master::isRemovable(const
TaskState&)`.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55475/
-----------------------------------------------------------
(Updated Jan. 21, 2017, 7:49 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-6619
https://issues.apache.org/jira/browse/MESOS-6619
Repository: mesos
Description
-------
This determines whether a task in the given state can safely be
discarded from the master's in-memory state. When a task becomes
removable, we move the task from the master's main task data structures
to a fixed-size cache (either the "unreachable" or "completed" task
list, as appropriate).
Diffs (updated)
-----
src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b
src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
Diff: https://reviews.apache.org/r/55475/diff/
Testing
-------
`make check`
Thanks,
Neil Conway