You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2018/02/23 17:18:09 UTC
svn commit: r1825140 -
/pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/BookmarkValidationProcess.java
Author: tilman
Date: Fri Feb 23 17:18:09 2018
New Revision: 1825140
URL: http://svn.apache.org/viewvc?rev=1825140&view=rev
Log:
PDFBOX-4122: avoid potential NPE
Modified:
pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/BookmarkValidationProcess.java
Modified: pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/BookmarkValidationProcess.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/BookmarkValidationProcess.java?rev=1825140&r1=1825139&r2=1825140&view=diff
==============================================================================
--- pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/BookmarkValidationProcess.java (original)
+++ pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/BookmarkValidationProcess.java Fri Feb 23 17:18:09 2018
@@ -157,6 +157,13 @@ public class BookmarkValidationProcess e
"Loop detected: /Next " + currentObj + " is already in the list"));
return false;
}
+ if (realPrevObject == null)
+ {
+ // unclear if this can ever happen
+ addValidationError(ctx, new ValidationError(ERROR_SYNTAX_TRAILER_OUTLINES_INVALID,
+ "Outline object before " + currentObj + " is null"));
+ return false;
+ }
levelObjects.add(currentObj);
currentItem = currentItem.getNextSibling();
if (currentItem == null)