You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/11/28 23:27:57 UTC
[GitHub] [netbeans] junichi11 commented on a change in pull request #1691:
Support vendor specific JVM options in Payara Server
junichi11 commented on a change in pull request #1691: Support vendor specific JVM options in Payara Server
URL: https://github.com/apache/netbeans/pull/1691#discussion_r351943040
##########
File path: enterprise/payara.tooling/src/org/netbeans/modules/payara/tooling/data/JDKVersion.java
##########
@@ -54,19 +59,27 @@
private static final Short DEFAULT_VALUE = 0;
- private JDKVersion(String string) {
- String[] split = string.split(VERSION_SPLITTER);
+ private JDKVersion(String version) {
+ if (version.contains("-")) {
+ String[] versionSplit = version.split("-");
+ vendor = versionSplit.length > 0 ? Optional.of(versionSplit[0]) : Optional.empty();
+ version = versionSplit.length > 1 ? versionSplit[1] : "";
Review comment:
Please add `// NOI18N`s. Strings of other files as well.
e.g.
```java
if (version.contains("-")) { // NOI18N
String[] versionSplit = version.split("-"); // NOI18N
vendor = versionSplit.length > 0 ? Optional.of(versionSplit[0]) : Optional.empty();
version = versionSplit.length > 1 ? versionSplit[1] : ""; // NOI18N
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists