You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "twalthr (via GitHub)" <gi...@apache.org> on 2023/10/31 11:22:16 UTC

[PR] [FLINK-25809][table] Improve readability of TableTestPrograms [flink]

twalthr opened a new pull request, #23632:
URL: https://github.com/apache/flink/pull/23632

   ## What is the purpose of the change
   
   From first feedback, this PR improves the readability of TableTestPrograms.
   
   ## Brief change log
   
   - Use a proper builder pattern for `SourceTestStep` and `SinkTestStep`
   - Give builder methods a better name (indicate when it `add` or sets, indicate whether data is `produced` or `consumed`)
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? JavaDocs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-25809][table] Improve readability of TableTestPrograms [flink]

Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr merged PR #23632:
URL: https://github.com/apache/flink/pull/23632


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-25809][table] Improve readability of TableTestPrograms [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23632:
URL: https://github.com/apache/flink/pull/23632#issuecomment-1787040309

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5c38577d5cdd88866181ce4c744fd8f0026dbb0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b5c38577d5cdd88866181ce4c744fd8f0026dbb0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b5c38577d5cdd88866181ce4c744fd8f0026dbb0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org