You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/08/07 16:00:12 UTC
[GitHub] [lucene] gsmiller opened a new pull request #237: LUCENE-10047: Fix value de-duping check in LongValueFacetCounts and RangeFacetCounts
gsmiller opened a new pull request #237:
URL: https://github.com/apache/lucene/pull/237
# Description
These two facet counting implementations are incorrectly assuming that -1 is an invalid value (for the purpose of value de-duping), which isn't the case.
# Solution
Fix the above assumption.
# Tests
Existing randomized testing caught the bug. Tests now pass.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #237: LUCENE-10047: Fix value de-duping check in LongValueFacetCounts and RangeFacetCounts
Posted by GitBox <gi...@apache.org>.
gsmiller commented on pull request #237:
URL: https://github.com/apache/lucene/pull/237#issuecomment-894681508
Pushing without a review to unblock broken nightly build test runs. Happy to tweak this further if anyone has feedback though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller merged pull request #237: LUCENE-10047: Fix value de-duping check in LongValueFacetCounts and RangeFacetCounts
Posted by GitBox <gi...@apache.org>.
gsmiller merged pull request #237:
URL: https://github.com/apache/lucene/pull/237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org