You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jc...@apache.org on 2010/08/12 16:23:34 UTC
svn commit: r984800 -
/wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
Author: jcompagner
Date: Thu Aug 12 14:23:34 2010
New Revision: 984800
URL: http://svn.apache.org/viewvc?rev=984800&view=rev
Log:
fix for double characters autocomplete and Upper Case
Modified:
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
Modified: wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js?rev=984800&r1=984799&r2=984800&view=diff
==============================================================================
--- wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js (original)
+++ wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js Thu Aug 12 14:23:34 2010
@@ -97,7 +97,7 @@ Wicket.AutoComplete=function(elementId,
objonchangeoriginal=obj.onchange;
obj.onchange=function(event){
if(mouseactive==1)return false;
- if(typeof objonchangeoriginal=="function")objonchangeoriginal.apply(this,[event]);
+ if(typeof objonchangeoriginal=="function") return objonchangeoriginal.apply(this,[event]);
}
objonchange=obj.onchange;
@@ -108,7 +108,7 @@ Wicket.AutoComplete=function(elementId,
return killEvent(event);
}
hideAutoComplete();
- if(typeof objonblur=="function")objonblur.apply(this,[event]);
+ if(typeof objonblur=="function") return objonblur.apply(this,[event]);
}
obj.onfocus=function(event){
@@ -124,7 +124,7 @@ Wicket.AutoComplete=function(elementId,
}
}
ignoreOneFocusGain = false;
- if(typeof objonfocus=="function")objonfocus.apply(this,[event]);
+ if(typeof objonfocus=="function") return objonfocus.apply(this,[event]);
}
obj.onkeydown=function(event){
@@ -170,7 +170,7 @@ Wicket.AutoComplete=function(elementId,
hidingAutocomplete = 1;
}
mouseactive = 0;
- if (typeof objonkeydown=="function") objonkeydown.apply(this,[event]);
+ if (typeof objonkeydown=="function") return objonkeydown.apply(this,[event]);
return true;
break;
default:
@@ -194,7 +194,7 @@ Wicket.AutoComplete=function(elementId,
default:
updateChoices();
}
- if(typeof objonkeyup=="function")objonkeyup.apply(this,[event]);
+ if(typeof objonkeyup=="function") return objonkeyup.apply(this,[event]);
}
obj.onkeypress=function(event){
@@ -204,7 +204,7 @@ Wicket.AutoComplete=function(elementId,
return killEvent(event);
}
}
- if(typeof objonkeypress=="function")objonkeypress.apply(this,[event]);
+ if(typeof objonkeypress=="function") return objonkeypress.apply(this,[event]);
}
}
Re: svn commit: r984800 - /wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
Posted by Johan Compagner <jc...@gmail.com>.
thats something else but i also fixed that one quickly
On Thu, Aug 12, 2010 at 16:57, Martin Grigorov <mg...@apache.org> wrote:
> Is this related to https://issues.apache.org/jira/browse/WICKET-2977 or this
> is something different ?
>
> On Thu, Aug 12, 2010 at 4:23 PM, <jc...@apache.org> wrote:
>
>> Author: jcompagner
>> Date: Thu Aug 12 14:23:34 2010
>> New Revision: 984800
>>
>> URL: http://svn.apache.org/viewvc?rev=984800&view=rev
>> Log:
>> fix for double characters autocomplete and Upper Case
>>
>> Modified:
>>
>> wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
>>
>> Modified:
>> wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
>> URL:
>> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js?rev=984800&r1=984799&r2=984800&view=diff
>>
>> ==============================================================================
>> ---
>> wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
>> (original)
>> +++
>> wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
>> Thu Aug 12 14:23:34 2010
>> @@ -97,7 +97,7 @@ Wicket.AutoComplete=function(elementId,
>> objonchangeoriginal=obj.onchange;
>> obj.onchange=function(event){
>> if(mouseactive==1)return false;
>> - if(typeof
>> objonchangeoriginal=="function")objonchangeoriginal.apply(this,[event]);
>> + if(typeof objonchangeoriginal=="function") return
>> objonchangeoriginal.apply(this,[event]);
>> }
>> objonchange=obj.onchange;
>>
>> @@ -108,7 +108,7 @@ Wicket.AutoComplete=function(elementId,
>> return killEvent(event);
>> }
>> hideAutoComplete();
>> - if(typeof
>> objonblur=="function")objonblur.apply(this,[event]);
>> + if(typeof objonblur=="function") return
>> objonblur.apply(this,[event]);
>> }
>>
>> obj.onfocus=function(event){
>> @@ -124,7 +124,7 @@ Wicket.AutoComplete=function(elementId,
>> }
>> }
>> ignoreOneFocusGain = false;
>> - if(typeof
>> objonfocus=="function")objonfocus.apply(this,[event]);
>> + if(typeof objonfocus=="function") return
>> objonfocus.apply(this,[event]);
>> }
>>
>> obj.onkeydown=function(event){
>> @@ -170,7 +170,7 @@ Wicket.AutoComplete=function(elementId,
>> hidingAutocomplete = 1;
>> }
>> mouseactive = 0;
>> - if (typeof objonkeydown=="function")
>> objonkeydown.apply(this,[event]);
>> + if (typeof objonkeydown=="function") return
>> objonkeydown.apply(this,[event]);
>> return true;
>> break;
>> default:
>> @@ -194,7 +194,7 @@ Wicket.AutoComplete=function(elementId,
>> default:
>> updateChoices();
>> }
>> - if(typeof
>> objonkeyup=="function")objonkeyup.apply(this,[event]);
>> + if(typeof objonkeyup=="function") return
>> objonkeyup.apply(this,[event]);
>> }
>>
>> obj.onkeypress=function(event){
>> @@ -204,7 +204,7 @@ Wicket.AutoComplete=function(elementId,
>> return killEvent(event);
>> }
>> }
>> - if(typeof
>> objonkeypress=="function")objonkeypress.apply(this,[event]);
>> + if(typeof objonkeypress=="function") return
>> objonkeypress.apply(this,[event]);
>> }
>> }
>>
>>
>>
>>
>
Re: svn commit: r984800 - /wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
Posted by Martin Grigorov <mg...@apache.org>.
Is this related to https://issues.apache.org/jira/browse/WICKET-2977 or this
is something different ?
On Thu, Aug 12, 2010 at 4:23 PM, <jc...@apache.org> wrote:
> Author: jcompagner
> Date: Thu Aug 12 14:23:34 2010
> New Revision: 984800
>
> URL: http://svn.apache.org/viewvc?rev=984800&view=rev
> Log:
> fix for double characters autocomplete and Upper Case
>
> Modified:
>
> wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
>
> Modified:
> wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
> URL:
> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js?rev=984800&r1=984799&r2=984800&view=diff
>
> ==============================================================================
> ---
> wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
> (original)
> +++
> wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
> Thu Aug 12 14:23:34 2010
> @@ -97,7 +97,7 @@ Wicket.AutoComplete=function(elementId,
> objonchangeoriginal=obj.onchange;
> obj.onchange=function(event){
> if(mouseactive==1)return false;
> - if(typeof
> objonchangeoriginal=="function")objonchangeoriginal.apply(this,[event]);
> + if(typeof objonchangeoriginal=="function") return
> objonchangeoriginal.apply(this,[event]);
> }
> objonchange=obj.onchange;
>
> @@ -108,7 +108,7 @@ Wicket.AutoComplete=function(elementId,
> return killEvent(event);
> }
> hideAutoComplete();
> - if(typeof
> objonblur=="function")objonblur.apply(this,[event]);
> + if(typeof objonblur=="function") return
> objonblur.apply(this,[event]);
> }
>
> obj.onfocus=function(event){
> @@ -124,7 +124,7 @@ Wicket.AutoComplete=function(elementId,
> }
> }
> ignoreOneFocusGain = false;
> - if(typeof
> objonfocus=="function")objonfocus.apply(this,[event]);
> + if(typeof objonfocus=="function") return
> objonfocus.apply(this,[event]);
> }
>
> obj.onkeydown=function(event){
> @@ -170,7 +170,7 @@ Wicket.AutoComplete=function(elementId,
> hidingAutocomplete = 1;
> }
> mouseactive = 0;
> - if (typeof objonkeydown=="function")
> objonkeydown.apply(this,[event]);
> + if (typeof objonkeydown=="function") return
> objonkeydown.apply(this,[event]);
> return true;
> break;
> default:
> @@ -194,7 +194,7 @@ Wicket.AutoComplete=function(elementId,
> default:
> updateChoices();
> }
> - if(typeof
> objonkeyup=="function")objonkeyup.apply(this,[event]);
> + if(typeof objonkeyup=="function") return
> objonkeyup.apply(this,[event]);
> }
>
> obj.onkeypress=function(event){
> @@ -204,7 +204,7 @@ Wicket.AutoComplete=function(elementId,
> return killEvent(event);
> }
> }
> - if(typeof
> objonkeypress=="function")objonkeypress.apply(this,[event]);
> + if(typeof objonkeypress=="function") return
> objonkeypress.apply(this,[event]);
> }
> }
>
>
>
>