You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/10/29 21:54:04 UTC
[GitHub] [iceberg] szehon-ho opened a new pull request #3422: Doc: Update Files metadata table
szehon-ho opened a new pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422
Files metadata table was missing some columns, and also missing an example for partitioned tables (users may want to know how to check what data files they have for a given partition)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-956375417
@kbendick, I think that we should convert lower and upper bounds into human-readable strings. Right now, I think we pass them to Spark as a map of id to binary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-994113288
Hey @samredai @rdblue , would we able to continue moving this forward? Was out on vacation, but my understanding is that we still keep the markdown files in this repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-955079135
cc @samredai as the docs refactor is underway 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on a change in pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on a change in pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#discussion_r740369655
##########
File path: site/docs/spark-queries.md
##########
@@ -209,16 +209,30 @@ To show a table's data files and each file's metadata, run:
```sql
SELECT * FROM prod.db.table.files
```
+
+For partitioned tables:
```text
-+-------------------------------------------------------------------------+-------------+--------------+--------------------+--------------------+------------------+-------------------+------------------+-----------------+-----------------+--------------+---------------+
-| file_path | file_format | record_count | file_size_in_bytes | column_sizes | value_counts | null_value_counts | nan_value_counts | lower_bounds | upper_bounds | key_metadata | split_offsets |
-+-------------------------------------------------------------------------+-------------+--------------+--------------------+--------------------+------------------+-------------------+------------------+-----------------+-----------------+--------------+---------------+
-| s3:/.../table/data/00000-3-8d6d60e8-d427-4809-bcf0-f5d45a4aad96.parquet | PARQUET | 1 | 597 | [1 -> 90, 2 -> 62] | [1 -> 1, 2 -> 1] | [1 -> 0, 2 -> 0] | [] | [1 -> , 2 -> c] | [1 -> , 2 -> c] | null | [4] |
-| s3:/.../table/data/00001-4-8d6d60e8-d427-4809-bcf0-f5d45a4aad96.parquet | PARQUET | 1 | 597 | [1 -> 90, 2 -> 62] | [1 -> 1, 2 -> 1] | [1 -> 0, 2 -> 0] | [] | [1 -> , 2 -> b] | [1 -> , 2 -> b] | null | [4] |
-| s3:/.../table/data/00002-5-8d6d60e8-d427-4809-bcf0-f5d45a4aad96.parquet | PARQUET | 1 | 597 | [1 -> 90, 2 -> 62] | [1 -> 1, 2 -> 1] | [1 -> 0, 2 -> 0] | [] | [1 -> , 2 -> a] | [1 -> , 2 -> a] | null | [4] |
-+-------------------------------------------------------------------------+-------------+--------------+--------------------+--------------------+------------------+-------------------+------------------+-----------------+-----------------+--------------+---------------+
++-------+-------------------------------------------------------------------------+-----------+---------------+------------+------------------+---------------------------+------------------------+------------------------+----------------+---------------------------------------+---------------------------------------+------------+-------------+------------+-------------+
Review comment:
Makes sense, let me look at this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#discussion_r739848024
##########
File path: site/docs/spark-queries.md
##########
@@ -209,16 +209,30 @@ To show a table's data files and each file's metadata, run:
```sql
SELECT * FROM prod.db.table.files
```
+
+For partitioned tables:
```text
-+-------------------------------------------------------------------------+-------------+--------------+--------------------+--------------------+------------------+-------------------+------------------+-----------------+-----------------+--------------+---------------+
-| file_path | file_format | record_count | file_size_in_bytes | column_sizes | value_counts | null_value_counts | nan_value_counts | lower_bounds | upper_bounds | key_metadata | split_offsets |
-+-------------------------------------------------------------------------+-------------+--------------+--------------------+--------------------+------------------+-------------------+------------------+-----------------+-----------------+--------------+---------------+
-| s3:/.../table/data/00000-3-8d6d60e8-d427-4809-bcf0-f5d45a4aad96.parquet | PARQUET | 1 | 597 | [1 -> 90, 2 -> 62] | [1 -> 1, 2 -> 1] | [1 -> 0, 2 -> 0] | [] | [1 -> , 2 -> c] | [1 -> , 2 -> c] | null | [4] |
-| s3:/.../table/data/00001-4-8d6d60e8-d427-4809-bcf0-f5d45a4aad96.parquet | PARQUET | 1 | 597 | [1 -> 90, 2 -> 62] | [1 -> 1, 2 -> 1] | [1 -> 0, 2 -> 0] | [] | [1 -> , 2 -> b] | [1 -> , 2 -> b] | null | [4] |
-| s3:/.../table/data/00002-5-8d6d60e8-d427-4809-bcf0-f5d45a4aad96.parquet | PARQUET | 1 | 597 | [1 -> 90, 2 -> 62] | [1 -> 1, 2 -> 1] | [1 -> 0, 2 -> 0] | [] | [1 -> , 2 -> a] | [1 -> , 2 -> a] | null | [4] |
-+-------------------------------------------------------------------------+-------------+--------------+--------------------+--------------------+------------------+-------------------+------------------+-----------------+-----------------+--------------+---------------+
++-------+-------------------------------------------------------------------------+-----------+---------------+------------+------------------+---------------------------+------------------------+------------------------+----------------+---------------------------------------+---------------------------------------+------------+-------------+------------+-------------+
Review comment:
Is it possible to not revert the formatting changes? I think it is less readable with the initial space removed.
Maybe we should replace this with a real HTML table?
Here's a snippet of code that we use in our notebooks to format PySpark dataframes as nicer tables:
```python
from prettytable import PrettyTable
from IPython.core.magic import register_line_cell_magic
class DFTable(PrettyTable):
def __repr__(self):
return self.get_string()
def _repr_html_(self):
return self.get_html_string()
def to_table(df, num_rows=100):
cols = df.columns
t = DFTable()
t.field_names = cols
t.align = "r"
for row in df.limit(num_rows).collect():
d = row.asDict()
t.add_row([ d[col] for col in cols ])
return t
```
That will produce both HTML and text tables that have reasonable formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] KnightChess commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
KnightChess commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-964704080
use scroll bar, there will be a empty line under the form when there is not overflow. did I not use it or optimize the scroll bar @szehon-ho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-962664868
The markdown table looks good to me. The only problem is that now just this table is markdown. Anyone want to follow up with an update for the other tables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-962664631
+1 to adding the scroll bar. Thanks @samredai!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] KnightChess commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
KnightChess commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-962757141
> The markdown table looks good to me. The only problem is that now just this table is markdown. Anyone want to follow up with an update for the other tables?
@rdblue I can update other tables in this pr #3482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-962248937
@rdblue @kbendick @samredai i made a markdown table for files, if you guys preview the file in github can see what it looks like. If you want i can extend this to the other ones too, or do it separately.
By the way i also found a possible problem in the spec_id column added in #3015 , it should probably get hidden just like partition column if table is unpartitioned, I could fix that in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-964775496
@KnightChess I'm not sure to be honest, can you put up your change on your pr? We can continue discussion on that pr instead of this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-962394057
GitHub injects some overflow css to add the scroll bar, if we switch to markdown tables we'd have to add that as well. Here's how the table currently would look:
<img width="1781" alt="Screen Shot 2021-11-05 at 9 22 44 PM" src="https://user-images.githubusercontent.com/43911210/140597755-5ca6eecc-8c89-4289-94fe-aba0baf7a231.png">
But adding the following:
### extra.css
```css
.markdown-table-container {
width: 780px;
overflow-x: scroll;
}
```
and then surrounding your markdown table with:
```html
<div class="markdown-table-container" markdown="block">
...markdown table here...
</div>
```
will make it look like this with the scrollbar:
<img width="1781" alt="Screen Shot 2021-11-05 at 9 44 05 PM" src="https://user-images.githubusercontent.com/43911210/140598189-38f0f601-061e-4b81-87c8-11bf03a7e1a7.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-994127990
@szehon-ho yes the plan is to keep the markdown files in this repo. There are some changes coming soon but any merged docs PR will be included. This looks good to me, I'll let @rdblue comment on if it's good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-994138704
Merged. Thanks, @szehon-ho!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-965199261
@szehon-ho can you update the CSS to the below? If we're using this for all markdown tables, `auto` will hide the scrollbar space that @KnightChess is seeing when the table width is below the container width.
```css
.markdown-table-container {
width: 780px;
overflow-x: auto;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho edited a comment on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
szehon-ho edited a comment on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-962248937
@rdblue @kbendick @samredai i made a markdown table for files, if you guys click 'View File' in github it should show what it looks like. If you want i can extend this to the other ones too, or do it separately.
By the way i also found a possible problem in the spec_id column added in #3015 , it should probably get hidden just like partition column if table is unpartitioned, I could fix that in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on a change in pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on a change in pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#discussion_r740369655
##########
File path: site/docs/spark-queries.md
##########
@@ -209,16 +209,30 @@ To show a table's data files and each file's metadata, run:
```sql
SELECT * FROM prod.db.table.files
```
+
+For partitioned tables:
```text
-+-------------------------------------------------------------------------+-------------+--------------+--------------------+--------------------+------------------+-------------------+------------------+-----------------+-----------------+--------------+---------------+
-| file_path | file_format | record_count | file_size_in_bytes | column_sizes | value_counts | null_value_counts | nan_value_counts | lower_bounds | upper_bounds | key_metadata | split_offsets |
-+-------------------------------------------------------------------------+-------------+--------------+--------------------+--------------------+------------------+-------------------+------------------+-----------------+-----------------+--------------+---------------+
-| s3:/.../table/data/00000-3-8d6d60e8-d427-4809-bcf0-f5d45a4aad96.parquet | PARQUET | 1 | 597 | [1 -> 90, 2 -> 62] | [1 -> 1, 2 -> 1] | [1 -> 0, 2 -> 0] | [] | [1 -> , 2 -> c] | [1 -> , 2 -> c] | null | [4] |
-| s3:/.../table/data/00001-4-8d6d60e8-d427-4809-bcf0-f5d45a4aad96.parquet | PARQUET | 1 | 597 | [1 -> 90, 2 -> 62] | [1 -> 1, 2 -> 1] | [1 -> 0, 2 -> 0] | [] | [1 -> , 2 -> b] | [1 -> , 2 -> b] | null | [4] |
-| s3:/.../table/data/00002-5-8d6d60e8-d427-4809-bcf0-f5d45a4aad96.parquet | PARQUET | 1 | 597 | [1 -> 90, 2 -> 62] | [1 -> 1, 2 -> 1] | [1 -> 0, 2 -> 0] | [] | [1 -> , 2 -> a] | [1 -> , 2 -> a] | null | [4] |
-+-------------------------------------------------------------------------+-------------+--------------+--------------------+--------------------+------------------+-------------------+------------------+-----------------+-----------------+--------------+---------------+
++-------+-------------------------------------------------------------------------+-----------+---------------+------------+------------------+---------------------------+------------------------+------------------------+----------------+---------------------------------------+---------------------------------------+------------+-------------+------------+-------------+
Review comment:
Makes sense, let me look at this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-956375417
@kbendick, I think that we should convert lower and upper bounds into human-readable strings. Right now, I think we pass them to Spark as a map of id to binary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-963828964
<img width="1529" alt="Screenshot 2021-11-08 at 21 22 30" src="https://user-images.githubusercontent.com/20555759/140867347-1e98f887-9ae8-48b2-ba58-b5ec0f8ae4e3.png">
Thanks @samredai and @rdblue for review , added the scroll bar using div and css as suggested. Attached screenshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-965598808
Done, thanks @KnightChess for finding the issue that would occur for the other table, and @samredai for figuring it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422#issuecomment-994168641
Thanks for fast response !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #3422: Doc: Update Files metadata table
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3422:
URL: https://github.com/apache/iceberg/pull/3422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org