You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2015/08/26 13:16:43 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-181 Provide more Feedbac...
GitHub user r-kamath opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/261
ZEPPELIN-181 Provide more Feedback on UI when Clicking the Cancel/Stop Button of a Pending/Running Paragraph
On branch ZEPPELIN-181
Changes to be committed:
modified: zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
modified: zeppelin-web/src/app/notebook/paragraph/paragraph.html
**screenshot** :
<img width="209" src="https://cloud.githubusercontent.com/assets/2031306/9492076/da030d62-4c11-11e5-8f67-688539442c8f.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/incubator-zeppelin ZEPPELIN-181
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/261.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #261
----
commit ff9748f81b9314a6fa915e8aa560b2d919f60e27
Author: Renjith Kamath <re...@gmail.com>
Date: 2015-08-26T11:13:08Z
ZEPPELIN-181 Provide more Feedback on UI when Clicking the Cancel/Stop Button of a Pending/Running Paragraph
Changes to be committed:
modified: zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
modified: zeppelin-web/src/app/notebook/paragraph/paragraph.html
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-181 Provide more Feedbac...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/261#issuecomment-134980907
Tried on my local, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-181 Provide more Feedbac...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/261#issuecomment-135295141
I think this should be handled at the Websocket/Backend level.
For example, after sending the CANCEL_PARAGRAPH, you will receive the note with paragraph.status as 'ABORT' once it is finished.
While you did set the pagraph.status to 'CANCELING', other people visiting the note would see it as 'PENDING' instead of 'CANCELING'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-181 Provide more Feedbac...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-181 Provide more Feedbac...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/261#issuecomment-135654070
@corneadoug @felixcheung thanks for the feedback. trying to make some changes in the server side to have CANCELING status. will post my updates here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-181 Provide more Feedbac...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/261#issuecomment-139471003
will reopen when the patch is ready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-181 Provide more Feedbac...
Posted by djoelz <gi...@git.apache.org>.
Github user djoelz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/261#issuecomment-136521442
and don't forget your unit tests :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-181 Provide more Feedbac...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/261#issuecomment-136520625
It'll broadcast 'CANCELING' event to connected browsers that is seeing the notebook.
However, if browser refreshes, it'll not see 'CANCELING' status any more.
As you mentioned, for completeness, i think it's better insert `CANCELING` status into state transition in Scheduler class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-181 Provide more Feedbac...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/261#issuecomment-136307043
@corneadoug let me know if the update is good. Currently the new status `CANCELING` is used only for `cancelParagraph` server call and in the UI.
@felixcheung @Leemoonsoo
>perhaps independent from this visual change, not everything is cancel-able from the interpreter?
For a complete implementation this status should be used in Scheduler classes as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---