You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/03/13 15:20:26 UTC
[GitHub] [accumulo] milleruntime edited a comment on issue #1027: Fix
possible bug and improve errors in Tablet
milleruntime edited a comment on issue #1027: Fix possible bug and improve errors in Tablet
URL: https://github.com/apache/accumulo/pull/1027#issuecomment-472468090
> It probably does not matter, but while looking at this I was wondering if the allocations related to the use of Optional were worth it.
I didn't about think this but Optional does allocate a new object for ever call to `Optional.of(commitSession)`.
I could create a NoOp CommitSession to call for bulkImport. Or just pass null and check for null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services