You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by mm...@apache.org on 2006/09/21 13:34:18 UTC

svn commit: r448522 - /myfaces/core/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java

Author: mmarinschek
Date: Thu Sep 21 04:34:17 2006
New Revision: 448522

URL: http://svn.apache.org/viewvc?view=rev&rev=448522
Log:
(re)fix for [MYFACES-1029] : Duplicate sibling ids allowed

Modified:
    myfaces/core/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java?view=diff&rev=448522&r1=448521&r2=448522
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java Thu Sep 21 04:34:17 2006
@@ -581,9 +581,7 @@
             // _childrenAdded is a Set, and we will stomp over a past id when calling 
             // addChildIdToParentTag.
             //
-            // It would also be reasonable to throw an exception here rather than
-            // just issue a warning as this is a pretty serious problem. However the
-            // Sun RI just issues a warning...
+            // we throw an exception here - RI issues a warning.
             if(parentTag._childrenAdded != null && parentTag._childrenAdded.contains(id))
             {
                 throw new FacesException("There is more than one JSF tag with id : " + id+" for parent component with id : '"+parent.getId()+"'");