You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/08/09 16:48:32 UTC
[GitHub] [camel] rikvb opened a new pull request #5945: CAMEL-16853: fix resultHandlerFactory, add unit test
rikvb opened a new pull request #5945:
URL: https://github.com/apache/camel/pull/5945
Unit test provided that demonstrates the flaw in current code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #5945: CAMEL-16853: fix resultHandlerFactory, add unit test
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #5945:
URL: https://github.com/apache/camel/pull/5945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rikvb commented on pull request #5945: CAMEL-16853: fix resultHandlerFactory, add unit test
Posted by GitBox <gi...@apache.org>.
rikvb commented on pull request #5945:
URL: https://github.com/apache/camel/pull/5945#issuecomment-896139486
Moved test to core, reverted changes to camel-xslt pom. Change is now just 1 new unit test and a 3-line move
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rikvb commented on pull request #5945: CAMEL-16853: fix resultHandlerFactory, add unit test
Posted by GitBox <gi...@apache.org>.
rikvb commented on pull request #5945:
URL: https://github.com/apache/camel/pull/5945#issuecomment-895752908
Apologies, I borrowed some code from saxon-xslt since it's very similar and forgot to check for this. I have rewritten the unit test using DSL and camel-test-junit5, but the cyclic dependency still exists:
cyclic reference: Edge between
'Vertex{label='org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT'}' and
'Vertex{label='org.apache.camel:camel-management:3.12.0-SNAPSHOT'}'
introduces to cycle in the graph
org.apache.camel:camel-management:3.12.0-SNAPSHOT
--> org.apache.camel:camel-core:3.12.0-SNAPSHOT
--> org.apache.camel:camel-xslt:3.12.0-SNAPSHOT
--> org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT
--> org.apache.camel:camel-management:3.12.0-SNAPSHOT @
Any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #5945: CAMEL-16853: fix resultHandlerFactory, add unit test
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5945:
URL: https://github.com/apache/camel/pull/5945#issuecomment-895486778
There is a cycle dependency with maven now
```
Error: ] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.apache.camel:camel-test-spring-junit5:3.12.0-SNAPSHOT'}' and 'Vertex{label='org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT'}' introduces to cycle in the graph org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT --> org.apache.camel:camel-management:3.12.0-SNAPSHOT --> org.apache.camel:camel-core:3.12.0-SNAPSHOT --> org.apache.camel:camel-xslt:3.12.0-SNAPSHOT --> org.apache.camel:camel-test-spring-junit5:3.12.0-SNAPSHOT --> org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT @
Error: The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.apache.camel:camel-test-spring-junit5:3.12.0-SNAPSHOT'}' and 'Vertex{label='org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT'}' introduces to cycle in the graph org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT --> org.apache.camel:camel-management:3.12.0-SNAPSHOT --> org.apache.camel:camel-core:3.12.0-SNAPSHOT --> org.apache.camel:camel-xslt:3.12.0-SNAPSHOT --> org.apache.camel:camel-test-spring-junit5:3.12.0-SNAPSHOT --> org.apache.camel:camel-test-junit5:3.12.0-SNAPSHOT -> [Help 1]
```
Can you avoid using camel-test-spring5 and just build a unit test that are Java DSL based
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #5945: CAMEL-16853: fix resultHandlerFactory, add unit test
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5945:
URL: https://github.com/apache/camel/pull/5945#issuecomment-895772865
Yes the unit test should not be in camel-xslt, but in core/camel-core, there are some xslt tests there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org