[superset] branch master updated: fix(chart & explore): Show labels for `SliderControl` (#19765)

[ru...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new dfbaba97c6 fix(chart & explore): Show labels for `SliderControl` (#19765)
dfbaba97c6 is described below

commit dfbaba97c61c28ecde8ce134a1f6ec385467c383
Author: smileydev <47...@users.noreply.github.com>
AuthorDate: Wed Apr 20 15:58:25 2022 -0400

    fix(chart & explore): Show labels for `SliderControl` (#19765)
    
    * fix(chart & explore): make to show label of slidercontrol
    
    * fix(chart & explore): make to update SliderControl props
    
    * fix(chart & explore): make to fix lint
---
 .../explore/components/controls/SliderControl.tsx  | 41 +++++++++++++++++++---
 1 file changed, 36 insertions(+), 5 deletions(-)

diff --git a/superset-frontend/src/explore/components/controls/SliderControl.tsx b/superset-frontend/src/explore/components/controls/SliderControl.tsx
index 5907e26ba8..a2d3b7c2bc 100644
--- a/superset-frontend/src/explore/components/controls/SliderControl.tsx
+++ b/superset-frontend/src/explore/components/controls/SliderControl.tsx
@@ -18,19 +18,50 @@
  */
 import React from 'react';
 import Slider from 'src/components/Slider';
-import ControlHeader from 'src/explore/components/ControlHeader';
+import ControlHeader, {
+  ControlHeaderProps,
+} from 'src/explore/components/ControlHeader';
 
-type SliderControlProps = {
+type SliderControlProps = ControlHeaderProps & {
   onChange: (value: number) => void;
   value: number;
   default?: number;
 };
 
-export default function SliderControl(props: SliderControlProps) {
-  const { onChange = () => {}, default: defaultValue, ...rest } = props;
+export default function SliderControl({
+  default: defaultValue,
+  name,
+  label,
+  description,
+  renderTrigger,
+  rightNode,
+  leftNode,
+  validationErrors,
+  hovered,
+  warning,
+  danger,
+  onClick,
+  tooltipOnClick,
+  onChange = () => {},
+  ...rest
+}: SliderControlProps) {
+  const headerProps = {
+    name,
+    label,
+    description,
+    renderTrigger,
+    rightNode,
+    leftNode,
+    validationErrors,
+    onClick,
+    hovered,
+    tooltipOnClick,
+    warning,
+    danger,
+  };
   return (
     <>
-      <ControlHeader />
+      <ControlHeader {...headerProps} />
       <Slider {...rest} onChange={onChange} defaultValue={defaultValue} />
     </>
   );