[GitHub] [geode] bschuchardt opened pull request #4508: GEODE-7544 Break dependency on ClassPathLoader

["bschuchardt (GitHub)" <gi...@apache.org>]

Look for the jgroups configuration file using regular class loaders
instead of geode-core's ClassPathLoader.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [tests already exist] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4508 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt closed pull request #4508: GEODE-7544 Break dependency on ClassPathLoader

["bschuchardt (GitHub)" <gi...@apache.org>]

[ pull request closed by bschuchardt ]

[ Full content available at: https://github.com/apache/geode/pull/4508 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on pull request #4508: GEODE-7544 Break dependency on ClassPathLoader

["Bill (GitHub)" <gi...@apache.org>]

thanks @bschuchardt 

[ Full content available at: https://github.com/apache/geode/pull/4508 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on pull request #4508: GEODE-7544 Break dependency on ClassPathLoader

["bschuchardt (GitHub)" <gi...@apache.org>]

ClassPathLoader exists to find customer classes in multiple contexts including J2EE servers, Web servers, regular gfsh-launched servers, etc.  Here we only need to find the JGroups configuration file, which will normally be found with ClassLoader.getSystemResourceAsStream(r).  I added the others because you really should look at the thread-context class-loader first and then, why not look at the class-loader for JGroupsMessenger as well (that's where I thought it would be found but I was wrong for the common case).

[ Full content available at: https://github.com/apache/geode/pull/4508 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org