You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Simone Tripodi <si...@apache.org> on 2012/07/19 13:44:01 UTC
[chain2] dropping @Deprecated methods
Hi all/Elijah,
during my current inspection I noticed some @Deprecated methods in the
web module - since we are jumping to a major release, it would be good
IMHO dropping them
WDYT? do you have a cycle to dedicate?
TIA,
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [chain2] dropping @Deprecated methods
Posted by Simone Tripodi <si...@apache.org>.
Hi Elijah!
well done and yes, go ahead and checkin the code yourself! :)
Please track the issue also in the src/changes/change.xml
TIA!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Sat, Jul 21, 2012 at 8:36 AM, Elijah Zupancic <el...@apache.org> wrote:
> I had a little time tonight to look at the deprecated methods again.
> This time around, the dependencies made more sense, so I just cut a
> patch that removes the deprecated methods. Please see:
> https://issues.apache.org/jira/browse/CHAIN-71
>
> Now, that I am a committer, can I go ahead and check in the changes
> and mark the issue as fixed if I get the ok from everyone on the
> mailing list?
>
> Thanks,
> -Elijah
>
> On Fri, Jul 20, 2012 at 12:32 AM, Simone Tripodi
> <si...@apache.org> wrote:
>>> Then again on the other hand, keeping deprecated APIs across major
>>> releases is not good. I'm very much undecided about this.
>>>
>>> -Elijah
>>
>> yup a major release with already deprecated methods doesn't look so good ;)
>> I'll have a look as well to provide some feedbacks/toughts
>> best,
>> -Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>>
>> On Fri, Jul 20, 2012 at 1:28 AM, Elijah Zupancic <el...@apache.org> wrote:
>>
>>>
>>> On Thu, Jul 19, 2012 at 4:27 PM, Elijah Zupancic <el...@apache.org> wrote:
>>>> Hi Simo,
>>>>
>>>> I've already partly investigated some of those methods. Some of them
>>>> are still used by the chain code, so I didn't just go ahead and delete
>>>> them. I believe they should be their own ticket. I would like to do it
>>>> in a 2.0.1 release. I want to get the new functionality proven and
>>>> burned in and then start to clean up the internals.
>>>>
>>>> -Elijah
>>>>
>>>> On Thu, Jul 19, 2012 at 4:44 AM, Simone Tripodi
>>>> <si...@apache.org> wrote:
>>>>> Hi all/Elijah,
>>>>>
>>>>> during my current inspection I noticed some @Deprecated methods in the
>>>>> web module - since we are jumping to a major release, it would be good
>>>>> IMHO dropping them
>>>>>
>>>>> WDYT? do you have a cycle to dedicate?
>>>>> TIA,
>>>>> -Simo
>>>>>
>>>>> http://people.apache.org/~simonetripodi/
>>>>> http://simonetripodi.livejournal.com/
>>>>> http://twitter.com/simonetripodi
>>>>> http://www.99soft.org/
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [chain2] dropping @Deprecated methods
Posted by Elijah Zupancic <el...@apache.org>.
I had a little time tonight to look at the deprecated methods again.
This time around, the dependencies made more sense, so I just cut a
patch that removes the deprecated methods. Please see:
https://issues.apache.org/jira/browse/CHAIN-71
Now, that I am a committer, can I go ahead and check in the changes
and mark the issue as fixed if I get the ok from everyone on the
mailing list?
Thanks,
-Elijah
On Fri, Jul 20, 2012 at 12:32 AM, Simone Tripodi
<si...@apache.org> wrote:
>> Then again on the other hand, keeping deprecated APIs across major
>> releases is not good. I'm very much undecided about this.
>>
>> -Elijah
>
> yup a major release with already deprecated methods doesn't look so good ;)
> I'll have a look as well to provide some feedbacks/toughts
> best,
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
> On Fri, Jul 20, 2012 at 1:28 AM, Elijah Zupancic <el...@apache.org> wrote:
>
>>
>> On Thu, Jul 19, 2012 at 4:27 PM, Elijah Zupancic <el...@apache.org> wrote:
>>> Hi Simo,
>>>
>>> I've already partly investigated some of those methods. Some of them
>>> are still used by the chain code, so I didn't just go ahead and delete
>>> them. I believe they should be their own ticket. I would like to do it
>>> in a 2.0.1 release. I want to get the new functionality proven and
>>> burned in and then start to clean up the internals.
>>>
>>> -Elijah
>>>
>>> On Thu, Jul 19, 2012 at 4:44 AM, Simone Tripodi
>>> <si...@apache.org> wrote:
>>>> Hi all/Elijah,
>>>>
>>>> during my current inspection I noticed some @Deprecated methods in the
>>>> web module - since we are jumping to a major release, it would be good
>>>> IMHO dropping them
>>>>
>>>> WDYT? do you have a cycle to dedicate?
>>>> TIA,
>>>> -Simo
>>>>
>>>> http://people.apache.org/~simonetripodi/
>>>> http://simonetripodi.livejournal.com/
>>>> http://twitter.com/simonetripodi
>>>> http://www.99soft.org/
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [chain2] dropping @Deprecated methods
Posted by Simone Tripodi <si...@apache.org>.
> Then again on the other hand, keeping deprecated APIs across major
> releases is not good. I'm very much undecided about this.
>
> -Elijah
yup a major release with already deprecated methods doesn't look so good ;)
I'll have a look as well to provide some feedbacks/toughts
best,
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Fri, Jul 20, 2012 at 1:28 AM, Elijah Zupancic <el...@apache.org> wrote:
>
> On Thu, Jul 19, 2012 at 4:27 PM, Elijah Zupancic <el...@apache.org> wrote:
>> Hi Simo,
>>
>> I've already partly investigated some of those methods. Some of them
>> are still used by the chain code, so I didn't just go ahead and delete
>> them. I believe they should be their own ticket. I would like to do it
>> in a 2.0.1 release. I want to get the new functionality proven and
>> burned in and then start to clean up the internals.
>>
>> -Elijah
>>
>> On Thu, Jul 19, 2012 at 4:44 AM, Simone Tripodi
>> <si...@apache.org> wrote:
>>> Hi all/Elijah,
>>>
>>> during my current inspection I noticed some @Deprecated methods in the
>>> web module - since we are jumping to a major release, it would be good
>>> IMHO dropping them
>>>
>>> WDYT? do you have a cycle to dedicate?
>>> TIA,
>>> -Simo
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://simonetripodi.livejournal.com/
>>> http://twitter.com/simonetripodi
>>> http://www.99soft.org/
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [chain2] dropping @Deprecated methods
Posted by Elijah Zupancic <el...@apache.org>.
Then again on the other hand, keeping deprecated APIs across major
releases is not good. I'm very much undecided about this.
-Elijah
On Thu, Jul 19, 2012 at 4:27 PM, Elijah Zupancic <el...@apache.org> wrote:
> Hi Simo,
>
> I've already partly investigated some of those methods. Some of them
> are still used by the chain code, so I didn't just go ahead and delete
> them. I believe they should be their own ticket. I would like to do it
> in a 2.0.1 release. I want to get the new functionality proven and
> burned in and then start to clean up the internals.
>
> -Elijah
>
> On Thu, Jul 19, 2012 at 4:44 AM, Simone Tripodi
> <si...@apache.org> wrote:
>> Hi all/Elijah,
>>
>> during my current inspection I noticed some @Deprecated methods in the
>> web module - since we are jumping to a major release, it would be good
>> IMHO dropping them
>>
>> WDYT? do you have a cycle to dedicate?
>> TIA,
>> -Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [chain2] dropping @Deprecated methods
Posted by Elijah Zupancic <el...@apache.org>.
Hi Simo,
I've already partly investigated some of those methods. Some of them
are still used by the chain code, so I didn't just go ahead and delete
them. I believe they should be their own ticket. I would like to do it
in a 2.0.1 release. I want to get the new functionality proven and
burned in and then start to clean up the internals.
-Elijah
On Thu, Jul 19, 2012 at 4:44 AM, Simone Tripodi
<si...@apache.org> wrote:
> Hi all/Elijah,
>
> during my current inspection I noticed some @Deprecated methods in the
> web module - since we are jumping to a major release, it would be good
> IMHO dropping them
>
> WDYT? do you have a cycle to dedicate?
> TIA,
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org