You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/30 06:03:53 UTC

[GitHub] [cloudstack] shwstppr opened a new pull request #5257: ui: fix import instance form for recent changes

shwstppr opened a new pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257


   ### Description
   
   7123269 and 535761b introduced changes that affecting Import Instance form.
   Custom compute selection was not showing properly.
   On import error was seen with 'AddAsyncJob'.
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889722972


   @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889795828


   @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889776773


   UI build: :heavy_multiplication_x:
    (SL-JID-453)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-891089409


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889774384


   @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr removed a comment on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889762832


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr removed a comment on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889795189


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr removed a comment on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889774075


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889722439


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr removed a comment on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889722439


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889795189


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889765379


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5257 (SL-JID-452)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez merged pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-891275888


   Merging based on approvals, no smoke tests required as are purely UI changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-891088704


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889725590


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5257 (SL-JID-451)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889774075


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889812518


   @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889798244


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5257 (SL-JID-456)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889725590






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889774384






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-891117841


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 728


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889763012


   @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889814628


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5257 (SL-JID-458)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889763012






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889762832


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #5257: ui: fix import instance form for recent changes

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5257:
URL: https://github.com/apache/cloudstack/pull/5257#issuecomment-889812312


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org