[GitHub] tillrohrmann commented on a change in pull request #6943: [FLINK-10632][e2e] Running general purpose testing job with failure in per-job mode

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #6943: [FLINK-10632][e2e] Running general purpose testing job with failure in per-job mode
URL: https://github.com/apache/flink/pull/6943#discussion_r229343747
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh
 ##########
 @@ -22,6 +22,20 @@ source "$(dirname "$0")"/common_ha.sh
 
 TEST_PROGRAM_JAR=${END_TO_END_DIR}/flink-dataset-allround-test/target/DataSetAllroundTestProgram.jar
 
+function ha_cleanup() {
+  # don't call ourselves again for another signal interruption
+  trap "exit -1" INT
+  # don't call ourselves again for normal exit
+  trap "" EXIT
+
+  # kill the cluster and zookeeper
+  stop_watchdogs
+  shutdown_all
 
 Review comment:
   I think `shutdown_all` will be called by the test runner in `test-runner-common.sh`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services