[GitHub] [spark] LuciferYang commented on a diff in pull request #40613: Revert "[SPARK-39204][CORE] Change `Utils.createTempDir` and `Utils.createDirectory` call the same logic method in `JavaUtils`

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1153928232


##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -330,7 +351,9 @@ private[spark] object Utils extends Logging {
   def createTempDir(
       root: String = System.getProperty("java.io.tmpdir"),
       namePrefix: String = "spark"): File = {
-    JavaUtils.createTempDir(root, namePrefix)
+    val dir = createDirectory(root, namePrefix)

Review Comment:
   https://github.com/apache/spark/pull/36529#discussion_r1153918687
   
   @srowen @sadikovi 
   
   After this revert, they are two different implementations  I think this can solve the problem. For `JavaUtils.createTempDir`, I will find other ways to solve it, it is only call by test code now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org