You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "max-melentyev (via GitHub)" <gi...@apache.org> on 2025/03/20 20:54:52 UTC

[PR] Add IsIdempotent to ObservedQuery and ObservedBatch [cassandra-gocql-driver]

max-melentyev opened a new pull request, #1870:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1870

   To let observers know


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] Add IsIdempotent to ObservedQuery and ObservedBatch [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1870:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1870#issuecomment-2769579576

   Yeah I agree with that, I can make that change in #1868 but my implementation doesn't make them threadsafe, just reusable so if a user tries to change the query/batch object within an implementation of these observers then bad things might happen... 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] Add IsIdempotent to ObservedQuery and ObservedBatch [cassandra-gocql-driver]

Posted by "jameshartig (via GitHub)" <gi...@apache.org>.
jameshartig commented on PR #1870:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1870#issuecomment-2766360492

   In #1868 we're making Query/Batch reusable. I wonder if we should include those in the observations instead of piecemeal adding a bunch of fields from them. @joao-r-reis thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] Add IsIdempotent to ObservedQuery and ObservedBatch [cassandra-gocql-driver]

Posted by "max-melentyev (via GitHub)" <gi...@apache.org>.
max-melentyev commented on PR #1870:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1870#issuecomment-2784426604

   Cool! What do you think about adding custom data to a query/batch that is passed to observers? We use a context.WithValue() to pass query names to observer, but this approach can lead to errors because engineers can use the same context for different queries. Would be great to have an approach when data is assigned for individual queries.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] Add IsIdempotent to ObservedQuery and ObservedBatch [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1870:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1870#issuecomment-2792567396

   > Cool! What do you think about adding custom data to a query/batch that is passed to observers? We use a context.WithValue() to pass query names to observer, but this approach can lead to errors because engineers can use the same context for different queries. Would be great to have an approach when data is assigned for individual queries.
   
   This seems like a reasonable feature request but I'd recommend creating a new issue for this as it seems unrelated to this one. I'm handling the current one in #1868 by adding the original query/batch objects to the `Observed...` types.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] Add Query and Batch to ObservedQuery and ObservedBatch [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis closed pull request #1870: Add Query and Batch to ObservedQuery and ObservedBatch
URL: https://github.com/apache/cassandra-gocql-driver/pull/1870


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org