[GitHub] [iceberg] Fokko commented on a diff in pull request #6242: API: Restore the type of the identity transform

[GitBox <gi...@apache.org>]

Fokko commented on code in PR #6242:
URL: https://github.com/apache/iceberg/pull/6242#discussion_r1029148053


##########
api/src/main/java/org/apache/iceberg/transforms/Identity.java:
##########
@@ -105,6 +142,21 @@ public boolean isIdentity() {
     return true;
   }
 
+  @Override
+  public boolean equals(Object o) {

Review Comment:
   Yes, definitely. In the new situation, we only check for the memory reference (and that's okay since there is only one instance).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org