You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2010/11/04 22:24:43 UTC
[jira] Created: (AVRO-692) permit 1.2-format files to be read
permit 1.2-format files to be read
----------------------------------
Key: AVRO-692
URL: https://issues.apache.org/jira/browse/AVRO-692
Project: Avro
Issue Type: Improvement
Components: java
Reporter: Doug Cutting
Assignee: Doug Cutting
Fix For: 1.5.0
It might be useful to have the ability to read 1.2 format data files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-692) permit 1.2-format files to be read
Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969602#action_12969602 ]
Scott Carey commented on AVRO-692:
----------------------------------
+1 I did not review DataFileReader12.java in detail. I looked at the rest of the patch closely and it looks good. Related tests pass.
> permit 1.2-format files to be read
> ----------------------------------
>
> Key: AVRO-692
> URL: https://issues.apache.org/jira/browse/AVRO-692
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.5.0
>
> Attachments: AVRO-692.patch, AVRO-692.patch, test.avro12
>
>
> It might be useful to have the ability to read 1.2 format data files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-692) permit 1.2-format files to be read
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-692:
------------------------------
Attachment: AVRO-692.patch
Here's a new version of the patch that adds a static factory method, DataFileReader.openReader(), which looks at the file's version number and uses either the current implementation or the 1.2 implementation. The "tojson" tool and the MapReduce task are also updated to use this factory.
> permit 1.2-format files to be read
> ----------------------------------
>
> Key: AVRO-692
> URL: https://issues.apache.org/jira/browse/AVRO-692
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.5.0
>
> Attachments: AVRO-692.patch, AVRO-692.patch
>
>
> It might be useful to have the ability to read 1.2 format data files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-692) permit 1.2-format files to be read
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-692:
------------------------------
Attachment: test.avro12
A 1.2 format file, for tests.
> permit 1.2-format files to be read
> ----------------------------------
>
> Key: AVRO-692
> URL: https://issues.apache.org/jira/browse/AVRO-692
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.5.0
>
> Attachments: AVRO-692.patch, AVRO-692.patch, test.avro12
>
>
> It might be useful to have the ability to read 1.2 format data files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-692) permit 1.2-format files to be read
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-692:
------------------------------
Attachment: AVRO-692.patch
Here's the 1.2 file reader updated slightly so that it compiles in the current trunk.
This still needs tests. Perhaps we should add a small sample data file into subversion that we can read in a test?
> permit 1.2-format files to be read
> ----------------------------------
>
> Key: AVRO-692
> URL: https://issues.apache.org/jira/browse/AVRO-692
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.5.0
>
> Attachments: AVRO-692.patch
>
>
> It might be useful to have the ability to read 1.2 format data files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-692) permit 1.2-format files to be read
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-692:
------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I committed this.
> permit 1.2-format files to be read
> ----------------------------------
>
> Key: AVRO-692
> URL: https://issues.apache.org/jira/browse/AVRO-692
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.5.0
>
> Attachments: AVRO-692.patch, AVRO-692.patch, test.avro12
>
>
> It might be useful to have the ability to read 1.2 format data files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-692) permit 1.2-format files to be read
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-692:
------------------------------
Status: Patch Available (was: Open)
> permit 1.2-format files to be read
> ----------------------------------
>
> Key: AVRO-692
> URL: https://issues.apache.org/jira/browse/AVRO-692
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.5.0
>
> Attachments: AVRO-692.patch, AVRO-692.patch, test.avro12
>
>
> It might be useful to have the ability to read 1.2 format data files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-692) permit 1.2-format files to be read
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969567#action_12969567 ]
Doug Cutting commented on AVRO-692:
-----------------------------------
Unless there are objections, I'll commit this soon.
> permit 1.2-format files to be read
> ----------------------------------
>
> Key: AVRO-692
> URL: https://issues.apache.org/jira/browse/AVRO-692
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.5.0
>
> Attachments: AVRO-692.patch, AVRO-692.patch, test.avro12
>
>
> It might be useful to have the ability to read 1.2 format data files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.