[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #3040:
URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r593012573



##########
File path: arch/risc-v/src/esp32c3/esp32c3_irq.c
##########
@@ -166,6 +189,52 @@ void up_disable_irq(int cpuint)
   leave_critical_section(irqstate);
 }
 
+/****************************************************************************
+ * Name: esp32c3_bind_irq
+ *
+ * Description:
+ *   Bind IRQ and resource with given parameters.
+ *
+ * Input Parameters:
+ *   cpuint    - CPU interrupt ID
+ *   periphid  - Peripheral ID
+ *   prio      - Interrupt priority
+ *   flags     - Interrupt flags
+ *
+ * Returned Value:
+ *   Allocated CPU interrupt on success, a negated error on failure.
+ *
+ ****************************************************************************/
+
+int esp32c3_bind_irq(uint8_t cpuint, uint8_t periphid, uint8_t prio,

Review comment:
       Why was this function created? Isn't doing the same thing as `esp32_request_irq`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org