You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by tr...@apache.org on 2005/09/01 23:54:57 UTC
svn commit: r265788 - in /maven/components/trunk/maven-site/src/site:
apt/developers/development-guide.apt apt/plugin-overview.apt
xdoc/getting-started.xml
Author: trygvis
Date: Thu Sep 1 14:54:52 2005
New Revision: 265788
URL: http://svn.apache.org/viewcvs?rev=265788&view=rev
Log:
o Adding some more notes on how to create patches.
Modified:
maven/components/trunk/maven-site/src/site/apt/developers/development-guide.apt
maven/components/trunk/maven-site/src/site/apt/plugin-overview.apt
maven/components/trunk/maven-site/src/site/xdoc/getting-started.xml
Modified: maven/components/trunk/maven-site/src/site/apt/developers/development-guide.apt
URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-site/src/site/apt/developers/development-guide.apt?rev=265788&r1=265787&r2=265788&view=diff
==============================================================================
--- maven/components/trunk/maven-site/src/site/apt/developers/development-guide.apt (original)
+++ maven/components/trunk/maven-site/src/site/apt/developers/development-guide.apt Thu Sep 1 14:54:52 2005
@@ -59,6 +59,10 @@
* Name the file <<<MNG-<issue number>-<artifact id>.patch>>>.
+ * When adding the patch add a comment to the JIRA suggesting the commit message. For information on what to include
+ in a commit message please take a look at the existing commit messages. Currently the commit mails are sent to
+ {{{http://mail-archives.apache.org/mod_mbox/maven-dev/}dev@maven.apache.org}} with the subject prefix "svn commit".
+
[]
An example on how to create a patch from the command line:
@@ -69,7 +73,7 @@
If you are picking up an issue with a existing patch attached to the issue you can apply the patch to your working
directory directly from JIRA like this. The <<<wget>>> and <<<patch>>> commands will only be available if you are
- on a UNIX platform or Cygwin on windows.
+ on a UNIX platform or using Cygwin on windows.
---
$ wget -O - -q <URL to the patch from JIRA> | patch -p0
@@ -80,6 +84,14 @@
---
$ patch -p0 < MNG-123.patch
---
+
+ A couple of notes:
+
+ * If you are using another tool for creating patches, make sure that the patch doesn't include absolute paths.
+ Including absolute paths in the patch will make the useless for us as we most likely don't have the same directory
+ structure as you.
+
+ * Make sure that you follow our code style.
* Other useful Subversion commands while developing
Modified: maven/components/trunk/maven-site/src/site/apt/plugin-overview.apt
URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-site/src/site/apt/plugin-overview.apt?rev=265788&r1=265787&r2=265788&view=diff
==============================================================================
--- maven/components/trunk/maven-site/src/site/apt/plugin-overview.apt (original)
+++ maven/components/trunk/maven-site/src/site/apt/plugin-overview.apt Thu Sep 1 14:54:52 2005
@@ -82,7 +82,7 @@
[[2]] {{{plugin-management.html}Managing plugin configuration in large
projects}}
- [[3]] {{{plugin-configuration.html}Configuring plugins}}
+ [[3]] {{{getting-started.html#configuring_plugins}Configuring plugins}}
* Comparison to Maven 1.x Plugins
Modified: maven/components/trunk/maven-site/src/site/xdoc/getting-started.xml
URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-site/src/site/xdoc/getting-started.xml?rev=265788&r1=265787&r2=265788&view=diff
==============================================================================
--- maven/components/trunk/maven-site/src/site/xdoc/getting-started.xml (original)
+++ maven/components/trunk/maven-site/src/site/xdoc/getting-started.xml Thu Sep 1 14:54:52 2005
@@ -136,6 +136,7 @@
been done.
</p>
</subsection>
+ <a name="configuring_plugins"/>
<subsection name="Configuring Plugins">
<p>
What if you would like to customise whether a plugins is enabled, or how a plugin operates?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org