[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #1598: Time zone related be function

[GitBox <gi...@apache.org>]

HangyuanLiu commented on a change in pull request #1598: Time zone related be function
URL: https://github.com/apache/incubator-doris/pull/1598#discussion_r312823840
 
 

 ##########
 File path: be/src/runtime/datetime_value.h
 ##########
 @@ -331,10 +332,14 @@ class DateTimeValue {
 
     // Add interval 
     bool date_add_interval(const TimeInterval& interval, TimeUnit unit);
-
-    int unix_timestamp() const;
-
-    bool from_unixtime(int64_t);
+    
+    //unix_timestamp is called with a timezone argument,
+    //it returns seconds of the value of date literal since '1970-01-01 00:00:00' UTC
+    bool unix_timestamp(int64_t& timestamp, const std::string& timezone) const;
 
 Review comment:
   ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org