[GitHub] [ignite] ibessonov commented on a change in pull request #7310: IGNITE-12576 nodeId replaced with consistentId in TcpCommunicationSpi for usability purposes.

[GitBox <gi...@apache.org>]

ibessonov commented on a change in pull request #7310: IGNITE-12576 nodeId replaced with consistentId in TcpCommunicationSpi for usability purposes.
URL: https://github.com/apache/ignite/pull/7310#discussion_r371646923
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationMetricsListener.java
 ##########
 @@ -82,10 +83,22 @@
     private final Function<Short, LongAdderMetric> rcvdMsgsCntByTypeMetricFactory;
 
     /** Function to be used in {@link Map#computeIfAbsent(Object, Function)} of {@code sentMsgsMetricsByNodeId}. */
-    private final Function<UUID, LongAdderMetric> sentMsgsCntByNodeIdMetricFactory;
+    private final Function<UUID, AtomicLong> sentMsgsCntByNodeIdMetricFactory;
 
 Review comment:
   These things won't be exported as metrics. We have them for JMX support only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services