You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "imp2002 (via GitHub)" <gi...@apache.org> on 2023/03/13 04:41:17 UTC

[GitHub] [rocketmq-spring] imp2002 opened a new pull request, #541: [ISSUE #539] Feat: support SpringBoot 3.x

imp2002 opened a new pull request, #541:
URL: https://github.com/apache/rocketmq-spring/pull/541

## What is the purpose of the change

Support SpringBoot 3.x.

Springboot-3.0 has abandoned `spring.factories` automatic assembly, it's replace by `/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports`, add this file for compatibility.

[reference](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Migration-Guide#auto-configuration-files)

## Brief changelog

Support SpringBoot 3.x

## Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.

- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #539] Feat: support SpringBoot 3.x [rocketmq-spring]

Posted by "988494 (via GitHub)" <gi...@apache.org>.

988494 commented on PR #541:
URL: https://github.com/apache/rocketmq-spring/pull/541#issuecomment-1765503508

   > 大家如果在升级到spring boot 3的时候遇到该问题，直接使用@import(RocketMQAutoConfiguration.class)配置即可
   
   监听也会出问题，后面还有很多问题，我基本都踩了一个遍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #539] Feat: support SpringBoot 3.x [rocketmq-spring]

Posted by "Routee (via GitHub)" <gi...@apache.org>.

Routee commented on PR #541:
URL: https://github.com/apache/rocketmq-spring/pull/541#issuecomment-1765783116

   > > 大家如果在升级到spring boot 3的时候遇到该问题，直接使用@import(RocketMQAutoConfiguration.class)配置即可
   > 
   > 监听也会出问题，后面还有很多问题，我基本都踩了一个遍
   
   那监听是怎么解决的啊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-spring] RongtongJin merged pull request #541: [ISSUE #539] Feat: support SpringBoot 3.x

Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.

RongtongJin merged PR #541:
URL: https://github.com/apache/rocketmq-spring/pull/541


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-spring] KongZouXiang commented on pull request #541: [ISSUE #539] Feat: support SpringBoot 3.x

Posted by "KongZouXiang (via GitHub)" <gi...@apache.org>.

KongZouXiang commented on PR #541:
URL: https://github.com/apache/rocketmq-spring/pull/541#issuecomment-1552330420

   I had the same problem today. Why didn't anyone merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-spring] yinyuncan commented on pull request #541: [ISSUE #539] Feat: support SpringBoot 3.x

Posted by "yinyuncan (via GitHub)" <gi...@apache.org>.

yinyuncan commented on PR #541:
URL: https://github.com/apache/rocketmq-spring/pull/541#issuecomment-1706016490

   大家如果在升级到spring boot 3的时候遇到该问题，直接使用@Import(RocketMQAutoConfiguration.class) 配置即可


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-spring] waitttttttttttttttttttttttting commented on pull request #541: [ISSUE #539] Feat: support SpringBoot 3.x

Posted by "waitttttttttttttttttttttttting (via GitHub)" <gi...@apache.org>.

waitttttttttttttttttttttttting commented on PR #541:
URL: https://github.com/apache/rocketmq-spring/pull/541#issuecomment-1573246562

   > I had the same problem today. Why didn't anyone merge
   
   +1 me too，


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #539] Feat: support SpringBoot 3.x [rocketmq-spring]

Posted by "xuxiaocong (via GitHub)" <gi...@apache.org>.

xuxiaocong commented on PR #541:
URL: https://github.com/apache/rocketmq-spring/pull/541#issuecomment-1775030643

   入口类增加
   @Import(RocketMQAutoConfiguration.class)
   
   配置需要下面三个
   rocketmq.name-server=xxx
   rocketmq.producer.group=xxx
   rocketmq.pull-consumer.group=xxx  # 无法监听的增加这个配置就行了


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org