You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2010/08/31 17:48:54 UTC
[jira] Reopened: (WICKET-3024) HttpsRequestChecker inadvertently
instantiates page when checking for annotation
[ https://issues.apache.org/jira/browse/WICKET-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl reopened WICKET-3024:
--------------------------------
the test case was broken as it still relied on HttpsRequestChecker calling getPage() which is wrong.
Patch for fixing test case is attached.
> HttpsRequestChecker inadvertently instantiates page when checking for annotation
> --------------------------------------------------------------------------------
>
> Key: WICKET-3024
> URL: https://issues.apache.org/jira/browse/WICKET-3024
> Project: Wicket
> Issue Type: Bug
> Reporter: Peter Ertl
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2
>
> Attachments: https.patch
>
>
> when checking for https the page class unnecessarily instantiated which will cause premature execution of the page constructor. In my case I threw a redirect which was not handled properly. So this issue not only a matter on efficiency but also erroneous.
> patch follows in a sec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.