[GitHub] ivankelly commented on issue #832: Issue 620: Close the fileChannels for read when they are idle

[GitBox <gi...@apache.org>]

ivankelly commented on issue #832: Issue 620: Close the fileChannels for read when they are idle
URL: https://github.com/apache/bookkeeper/pull/832#issuecomment-370368461
 
 
   > I think the original implementation is much simpler approach.
   
   The original implementation had race conditions, where dead file channels would be handed out, which is why I suggested Arvin take a look at the refcounting stuff from the fileinfobackingcache, which dealt with a similar problem. The locking from the fileinfobackingcache is probably not needed though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services