You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/06 23:11:09 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32459: [SPARK-26164][SQL][FOLLOWUP] WriteTaskStatsTracker should know which file the row is written to
dongjoon-hyun commented on a change in pull request #32459:
URL: https://github.com/apache/spark/pull/32459#discussion_r627822072
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala
##########
@@ -151,7 +151,7 @@ class BasicWriteTaskStatsTracker(hadoopConf: Configuration)
}
}
- override def newRow(row: InternalRow): Unit = {
+ override def newRow(filePath: String, row: InternalRow): Unit = {
Review comment:
From Apache Side, this is no-op parameter and there is no test coverage in this PR. Do you think we can have a sample custom `WriteTaskStatsTracker` test case to prevent a future regression, @cloud-fan ?
> To not break some custom WriteTaskStatsTracker implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org