You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Danny McCormick (Jira)" <ji...@apache.org> on 2022/06/04 22:35:00 UTC
[jira] [Commented] (BEAM-13431) Use ProjectionConsumer in FieldAccessVisitor.
[ https://issues.apache.org/jira/browse/BEAM-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17549703#comment-17549703 ]
Danny McCormick commented on BEAM-13431:
----------------------------------------
This issue has been migrated to https://github.com/apache/beam/issues/21276
> Use ProjectionConsumer in FieldAccessVisitor.
> ---------------------------------------------
>
> Key: BEAM-13431
> URL: https://issues.apache.org/jira/browse/BEAM-13431
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Kyle Weaver
> Priority: P3
>
> I created an interface for ProjectionConsumer and then neglected to use it. Using ProjectionConsumer rather than handling transforms case-by-case will make FieldAccessVisitor easier to extend.
> Changing this would require ParDo.MultiOutput to implement ProjectionConsumer.
> https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/ProjectionConsumer.java
> https://github.com/apache/beam/blob/8a7ad0edd0ffe2a7b23efbe37567cf03aed82262/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/FieldAccessVisitor.java#L64
--
This message was sent by Atlassian Jira
(v8.20.7#820007)