[GitHub] [iotdb] yifuzhou commented on a diff in pull request #6002: [IOTDB-3258] implement count nodes

[GitBox <gi...@apache.org>]

yifuzhou commented on code in PR #6002:
URL: https://github.com/apache/iotdb/pull/6002#discussion_r881128142


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/LogicalPlanner.java:
##########
@@ -423,6 +424,15 @@ public PlanNode visitCountLevelTimeSeries(
           .getRoot();
     }
 
+    @Override
+    public PlanNode visitCountNodes(CountNodesStatement countStatement, MPPQueryContext context) {
+      LogicalPlanBuilder planBuilder = new LogicalPlanBuilder(context);
+      return planBuilder
+          .planChildPathsSchemaSource(countStatement.getPartialPath(), countStatement.getLevel())
+          .planCountMerge()
+          .getRoot();

Review Comment:
   How about both sg above and sg below need to count together? like there has sg: root.ln, root.abc.a1.a2.a3 and ts:root.ln.a1.a2.a3. We want count nodes root.** level=3? I think planNodeManagementMemoryMerge() should be used.



##########
confignode/src/test/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessorTest.java:
##########
@@ -1000,4 +1003,61 @@ private void cleanUserAndRole() throws TException {
       Assert.assertEquals(TSStatusCode.SUCCESS_STATUS.getStatusCode(), status.getCode());
     }
   }
+
+  @Test
+  public void testDeleteStorageGroup() throws TException {

Review Comment:
   It seems that previous pr changes has been removed... This function is the same as deleteStorageGroupTest(). I just change the name. Test class uses ....Test format and test function uses test... format should be more normalized.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org