You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/21 07:24:10 UTC

[GitHub] [incubator-mxnet] bgawrych opened a new pull request #19199: [BUGFIX] [v1.x] ElementWiseSum fix for oneDNN (#18777)

bgawrych opened a new pull request #19199:
URL: https://github.com/apache/incubator-mxnet/pull/19199


   Cherry-pick from https://github.com/apache/incubator-mxnet/pull/18777
   
   * Fix ElementwiseSum for DNNL
   
   * Fix sanity and replace push_back with emplace_back
   
   * Change order of the data format conditions
   
   * Add NOLINT to avoid readability error
   
   * Add test for oneDNN ElemwiseSum
   
   
   ## Description ##
   (Brief description on what this PR is about)
   
   ## Checklist ##
   ### Essentials ###
   - [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage
   - [x] Code is well-documented
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19199: [BUGFIX] [v1.x] ElementWiseSum fix for oneDNN (#18777)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19199:
URL: https://github.com/apache/incubator-mxnet/pull/19199#issuecomment-696551053


   Jenkins CI successfully triggered : [website]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #19199: [BUGFIX] [v1.x] ElementWiseSum fix for oneDNN (#18777)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #19199:
URL: https://github.com/apache/incubator-mxnet/pull/19199#issuecomment-696551010


   @mxnet-bot run ci [website]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19199: [BUGFIX] [v1.x] ElementWiseSum fix for oneDNN (#18777)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19199:
URL: https://github.com/apache/incubator-mxnet/pull/19199#issuecomment-695947970


   Hey @bgawrych , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [unix-cpu, website, edge, clang, windows-gpu, miscellaneous, centos-cpu, unix-gpu, windows-cpu, centos-gpu, sanity]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19199: [BUGFIX] [v1.x] ElementWiseSum fix for oneDNN (#18777)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19199:
URL: https://github.com/apache/incubator-mxnet/pull/19199#issuecomment-695947970


   Hey @bgawrych , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [unix-cpu, website, edge, clang, windows-gpu, miscellaneous, centos-cpu, unix-gpu, windows-cpu, centos-gpu, sanity]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] pengzhao-intel merged pull request #19199: [BUGFIX] [v1.x] ElementWiseSum fix for oneDNN (#18777)

Posted by GitBox <gi...@apache.org>.
pengzhao-intel merged pull request #19199:
URL: https://github.com/apache/incubator-mxnet/pull/19199


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19199: [BUGFIX] [v1.x] ElementWiseSum fix for oneDNN (#18777)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19199:
URL: https://github.com/apache/incubator-mxnet/pull/19199#issuecomment-696551053


   Jenkins CI successfully triggered : [website]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #19199: [BUGFIX] [v1.x] ElementWiseSum fix for oneDNN (#18777)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #19199:
URL: https://github.com/apache/incubator-mxnet/pull/19199#issuecomment-696551010


   @mxnet-bot run ci [website]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #19199: [BUGFIX] [v1.x] ElementWiseSum fix for oneDNN (#18777)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #19199:
URL: https://github.com/apache/incubator-mxnet/pull/19199#issuecomment-697168663


   @anko-intel @pengzhao-intel 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org