You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@polygene.apache.org by pa...@apache.org on 2016/10/24 11:41:20 UTC
[3/3] zest-java git commit: ZEST-180 Indexing-SQL uses the String
form of Identity
ZEST-180 Indexing-SQL uses the String form of Identity
Most of the tests still fail after the refactoring.
Project: http://git-wip-us.apache.org/repos/asf/zest-java/repo
Commit: http://git-wip-us.apache.org/repos/asf/zest-java/commit/520aa5f3
Tree: http://git-wip-us.apache.org/repos/asf/zest-java/tree/520aa5f3
Diff: http://git-wip-us.apache.org/repos/asf/zest-java/diff/520aa5f3
Branch: refs/heads/develop
Commit: 520aa5f38acc86cf8631e8a866e6cf844008d72c
Parents: 23f6bc1
Author: Paul Merlin <pa...@apache.org>
Authored: Mon Oct 24 13:40:49 2016 +0200
Committer: Paul Merlin <pa...@apache.org>
Committed: Mon Oct 24 13:40:49 2016 +0200
----------------------------------------------------------------------
.../zest/index/sql/support/skeletons/AbstractSQLQuerying.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zest-java/blob/520aa5f3/extensions/indexing-sql/src/main/java/org/apache/zest/index/sql/support/skeletons/AbstractSQLQuerying.java
----------------------------------------------------------------------
diff --git a/extensions/indexing-sql/src/main/java/org/apache/zest/index/sql/support/skeletons/AbstractSQLQuerying.java b/extensions/indexing-sql/src/main/java/org/apache/zest/index/sql/support/skeletons/AbstractSQLQuerying.java
index c6cc0d6..38ba1f8 100644
--- a/extensions/indexing-sql/src/main/java/org/apache/zest/index/sql/support/skeletons/AbstractSQLQuerying.java
+++ b/extensions/indexing-sql/src/main/java/org/apache/zest/index/sql/support/skeletons/AbstractSQLQuerying.java
@@ -1055,7 +1055,7 @@ public abstract class AbstractSQLQuerying
if( value instanceof EntityComposite )
{
value = uowf.currentUnitOfWork().get(
- (EntityComposite) value ).identity().get();
+ (EntityComposite) value ).identity().get().toString();
}
else
{
Re: [3/3] zest-java git commit: ZEST-180 Indexing-SQL uses the String
form of Identity
Posted by Niclas Hedhman <ni...@hedhman.org>.
Never mind,,, OUTSIDE the get().
On Mon, Oct 24, 2016 at 8:16 PM, Niclas Hedhman <ni...@hedhman.org> wrote:
> Hold on, what is this?? UnitOfWork.get() takes an Identity instance, not a
> string.
>
> On Mon, Oct 24, 2016 at 7:41 PM, <pa...@apache.org> wrote:
>
>> ZEST-180 Indexing-SQL uses the String form of Identity
>>
>> Most of the tests still fail after the refactoring.
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/zest-java/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/zest-java/commit/520aa5f3
>> Tree: http://git-wip-us.apache.org/repos/asf/zest-java/tree/520aa5f3
>> Diff: http://git-wip-us.apache.org/repos/asf/zest-java/diff/520aa5f3
>>
>> Branch: refs/heads/develop
>> Commit: 520aa5f38acc86cf8631e8a866e6cf844008d72c
>> Parents: 23f6bc1
>> Author: Paul Merlin <pa...@apache.org>
>> Authored: Mon Oct 24 13:40:49 2016 +0200
>> Committer: Paul Merlin <pa...@apache.org>
>> Committed: Mon Oct 24 13:40:49 2016 +0200
>>
>> ----------------------------------------------------------------------
>> .../zest/index/sql/support/skeletons/AbstractSQLQuerying.java | 2
>> +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/zest-java/blob/520aa5
>> f3/extensions/indexing-sql/src/main/java/org/apache/zest/
>> index/sql/support/skeletons/AbstractSQLQuerying.java
>> ----------------------------------------------------------------------
>> diff --git a/extensions/indexing-sql/src/main/java/org/apache/zest/inde
>> x/sql/support/skeletons/AbstractSQLQuerying.java
>> b/extensions/indexing-sql/src/main/java/org/apache/zest/inde
>> x/sql/support/skeletons/AbstractSQLQuerying.java
>> index c6cc0d6..38ba1f8 100644
>> --- a/extensions/indexing-sql/src/main/java/org/apache/zest/inde
>> x/sql/support/skeletons/AbstractSQLQuerying.java
>> +++ b/extensions/indexing-sql/src/main/java/org/apache/zest/inde
>> x/sql/support/skeletons/AbstractSQLQuerying.java
>> @@ -1055,7 +1055,7 @@ public abstract class AbstractSQLQuerying
>> if( value instanceof EntityComposite )
>> {
>> value = uowf.currentUnitOfWork().get(
>> - (EntityComposite) value ).identity().get();
>> + (EntityComposite) value
>> ).identity().get().toString();
>> }
>> else
>> {
>>
>>
>
>
> --
> Niclas Hedhman, Software Developer
> http://zest.apache.org - New Energy for Java
>
--
Niclas Hedhman, Software Developer
http://zest.apache.org - New Energy for Java
Re: [3/3] zest-java git commit: ZEST-180 Indexing-SQL uses the String
form of Identity
Posted by Niclas Hedhman <ni...@hedhman.org>.
Hold on, what is this?? UnitOfWork.get() takes an Identity instance, not a
string.
On Mon, Oct 24, 2016 at 7:41 PM, <pa...@apache.org> wrote:
> ZEST-180 Indexing-SQL uses the String form of Identity
>
> Most of the tests still fail after the refactoring.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/zest-java/repo
> Commit: http://git-wip-us.apache.org/repos/asf/zest-java/commit/520aa5f3
> Tree: http://git-wip-us.apache.org/repos/asf/zest-java/tree/520aa5f3
> Diff: http://git-wip-us.apache.org/repos/asf/zest-java/diff/520aa5f3
>
> Branch: refs/heads/develop
> Commit: 520aa5f38acc86cf8631e8a866e6cf844008d72c
> Parents: 23f6bc1
> Author: Paul Merlin <pa...@apache.org>
> Authored: Mon Oct 24 13:40:49 2016 +0200
> Committer: Paul Merlin <pa...@apache.org>
> Committed: Mon Oct 24 13:40:49 2016 +0200
>
> ----------------------------------------------------------------------
> .../zest/index/sql/support/skeletons/AbstractSQLQuerying.java | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/zest-java/blob/
> 520aa5f3/extensions/indexing-sql/src/main/java/org/apache/
> zest/index/sql/support/skeletons/AbstractSQLQuerying.java
> ----------------------------------------------------------------------
> diff --git a/extensions/indexing-sql/src/main/java/org/apache/zest/
> index/sql/support/skeletons/AbstractSQLQuerying.java
> b/extensions/indexing-sql/src/main/java/org/apache/zest/
> index/sql/support/skeletons/AbstractSQLQuerying.java
> index c6cc0d6..38ba1f8 100644
> --- a/extensions/indexing-sql/src/main/java/org/apache/zest/
> index/sql/support/skeletons/AbstractSQLQuerying.java
> +++ b/extensions/indexing-sql/src/main/java/org/apache/zest/
> index/sql/support/skeletons/AbstractSQLQuerying.java
> @@ -1055,7 +1055,7 @@ public abstract class AbstractSQLQuerying
> if( value instanceof EntityComposite )
> {
> value = uowf.currentUnitOfWork().get(
> - (EntityComposite) value ).identity().get();
> + (EntityComposite) value
> ).identity().get().toString();
> }
> else
> {
>
>
--
Niclas Hedhman, Software Developer
http://zest.apache.org - New Energy for Java