You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "chamikaramj (via GitHub)" <gi...@apache.org> on 2025/03/03 19:29:21 UTC
Re: [PR] [Managed Iceberg] unbounded source [beam]
chamikaramj commented on code in PR #33504:
URL: https://github.com/apache/beam/pull/33504#discussion_r1978073184
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergIO.java:
##########
@@ -50,29 +50,32 @@
* <pre>{@code
* Map<String, Object> config = Map.of(
* "table", table,
- * "triggering_frequency_seconds", 5,
* "catalog_name", name,
* "catalog_properties", Map.of(
* "warehouse", warehouse_path,
* "catalog-impl", "org.apache.iceberg.hive.HiveCatalog"),
* "config_properties", Map.of(
* "hive.metastore.uris", metastore_uri));
*
+ *
+ * ====== WRITE ======
* pipeline
* .apply(Create.of(BEAM_ROWS))
* .apply(Managed.write(ICEBERG).withConfig(config));
*
*
- * // ====== READ ======
+ * ====== READ ======
* pipeline
* .apply(Managed.read(ICEBERG).withConfig(config))
* .getSinglePCollection()
* .apply(ParDo.of(...));
* }</pre>
*
- * <h3>Configuration Options</h3>
+ * Look for more detailed examples below.
Review Comment:
We need to add Mananged API updates for this source ?
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergIO.java:
##########
@@ -50,29 +50,32 @@
* <pre>{@code
* Map<String, Object> config = Map.of(
* "table", table,
- * "triggering_frequency_seconds", 5,
* "catalog_name", name,
* "catalog_properties", Map.of(
* "warehouse", warehouse_path,
* "catalog-impl", "org.apache.iceberg.hive.HiveCatalog"),
* "config_properties", Map.of(
* "hive.metastore.uris", metastore_uri));
*
+ *
+ * ====== WRITE ======
* pipeline
* .apply(Create.of(BEAM_ROWS))
* .apply(Managed.write(ICEBERG).withConfig(config));
*
*
- * // ====== READ ======
+ * ====== READ ======
* pipeline
* .apply(Managed.read(ICEBERG).withConfig(config))
* .getSinglePCollection()
* .apply(ParDo.of(...));
* }</pre>
*
- * <h3>Configuration Options</h3>
+ * Look for more detailed examples below.
Review Comment:
We need to add Managed API updates for this source ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org