You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dlab.apache.org by GitBox <gi...@apache.org> on 2020/02/20 15:43:07 UTC
[GitHub] [incubator-dlab] ppapou opened a new pull request #611: [DLAB-1510]
All resourses are stopped with project
ppapou opened a new pull request #611: [DLAB-1510] All resourses are stopped with project
URL: https://github.com/apache/incubator-dlab/pull/611
According to related issue, the project's resourse should be stopped with initial project
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ppapou commented on issue #611: [DLAB-1510] All
resourses are stopped with project
Posted by GitBox <gi...@apache.org>.
ppapou commented on issue #611: [DLAB-1510] All resourses are stopped with project
URL: https://github.com/apache/incubator-dlab/pull/611#issuecomment-593761317
>
>
> Did you run tests?
The unitest has been adjusted, plus a new test has been added for the start resource
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ofuks merged pull request #611: [DLAB-1510] All
resourses are stopped with project
Posted by GitBox <gi...@apache.org>.
ofuks merged pull request #611: [DLAB-1510] All resourses are stopped with project
URL: https://github.com/apache/incubator-dlab/pull/611
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ofuks commented on a change in pull request #611:
[DLAB-1510] All resourses are stopped with project
Posted by GitBox <gi...@apache.org>.
ofuks commented on a change in pull request #611: [DLAB-1510] All resourses are stopped with project
URL: https://github.com/apache/incubator-dlab/pull/611#discussion_r386367688
##########
File path: services/self-service/src/test/java/com/epam/dlab/backendapi/resources/ProjectResourceTest.java
##########
@@ -17,6 +18,10 @@
import javax.ws.rs.core.MediaType;
import javax.ws.rs.core.Response;
+import java.util.AbstractList;
Review comment:
Do we need it here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ppapou commented on a change in pull request #611:
[DLAB-1510] All resourses are stopped with project
Posted by GitBox <gi...@apache.org>.
ppapou commented on a change in pull request #611: [DLAB-1510] All resourses are stopped with project
URL: https://github.com/apache/incubator-dlab/pull/611#discussion_r386793080
##########
File path: services/self-service/src/test/java/com/epam/dlab/backendapi/resources/ProjectResourceTest.java
##########
@@ -17,6 +18,10 @@
import javax.ws.rs.core.MediaType;
import javax.ws.rs.core.Response;
+import java.util.AbstractList;
Review comment:
import section has been optimized
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ppapou commented on a change in pull request #611:
[DLAB-1510] All resourses are stopped with project
Posted by GitBox <gi...@apache.org>.
ppapou commented on a change in pull request #611: [DLAB-1510] All resourses are stopped with project
URL: https://github.com/apache/incubator-dlab/pull/611#discussion_r386793318
##########
File path: services/self-service/src/test/java/com/epam/dlab/backendapi/resources/ProjectResourceTest.java
##########
@@ -98,4 +115,11 @@ public void generateKeysWithException() {
verify(keyService).generateKeys(getUserInfo());
verifyNoMoreInteractions(keyService);
}
-}
\ No newline at end of file
+
+ private ProjectActionFormDTO getProjectAvtionDTO() {
+ List<String> endPoints = new ArrayList<>();
+ endPoints.add("https://localhost:8083/");
+ String projectName = "DLAB";
+ return new ProjectActionFormDTO(projectName, endPoints);
Review comment:
the singleton list has been used to reduce the code lines number
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ofuks commented on a change in pull request #611:
[DLAB-1510] All resourses are stopped with project
Posted by GitBox <gi...@apache.org>.
ofuks commented on a change in pull request #611: [DLAB-1510] All resourses are stopped with project
URL: https://github.com/apache/incubator-dlab/pull/611#discussion_r386367527
##########
File path: services/self-service/src/test/java/com/epam/dlab/backendapi/resources/ProjectResourceTest.java
##########
@@ -98,4 +115,11 @@ public void generateKeysWithException() {
verify(keyService).generateKeys(getUserInfo());
verifyNoMoreInteractions(keyService);
}
-}
\ No newline at end of file
+
+ private ProjectActionFormDTO getProjectAvtionDTO() {
+ List<String> endPoints = new ArrayList<>();
+ endPoints.add("https://localhost:8083/");
+ String projectName = "DLAB";
+ return new ProjectActionFormDTO(projectName, endPoints);
Review comment:
Use Collections.singletonList insead of ** endPoints**. And inline ProjectActionFormDTO object creation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org