You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sebastianliebscher (via GitHub)" <gi...@apache.org> on 2023/05/02 08:03:31 UTC
[GitHub] [superset] sebastianliebscher opened a new issue, #23899: package 'pkg_resource' is deprecated in favor of importlib
sebastianliebscher opened a new issue, #23899:
URL: https://github.com/apache/superset/issues/23899
The package `pkg_resource` is officially deprecated in favor of importlib: https://setuptools.pypa.io/en/latest/pkg_resources.html
> Use of pkg_resources is discouraged in favor of [importlib.resources](https://docs.python.org/3/library/importlib.html#module-importlib.resources), [importlib.metadata](https://docs.python.org/3/library/importlib.metadata.html), and their backports ([resources](https://pypi.org/project/importlib_resources), [metadata](https://pypi.org/project/importlib_metadata)). Please consider using those libraries instead of pkg_resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] package 'pkg_resource' is deprecated in favor of importlib [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #23899:
URL: https://github.com/apache/superset/issues/23899#issuecomment-1981878072
@cwegener @sebastianliebscher can you advise us on the current status of this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] package 'pkg_resource' is deprecated in favor of importlib [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #23899:
URL: https://github.com/apache/superset/issues/23899#issuecomment-2612424907
Fixed in https://github.com/apache/superset/pull/31411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] package 'pkg_resource' is deprecated in favor of importlib [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina closed issue #23899: package 'pkg_resource' is deprecated in favor of importlib
URL: https://github.com/apache/superset/issues/23899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] package 'pkg_resource' is deprecated in favor of importlib [superset]
Posted by "cwegener (via GitHub)" <gi...@apache.org>.
cwegener commented on issue #23899:
URL: https://github.com/apache/superset/issues/23899#issuecomment-1982430992
`UPLOAD_FOLDER` logic still needs to be changed in order to get rid of this last remaining `pkg_resources` import ... https://github.com/apache/superset/blob/ce0b70cc8685aa4d83c0c4ad0fb8f03fb7e28ede/superset/config.py#L79
It's an easy change to do, but will be a breaking change.
I'll create a PR for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sebastianliebscher commented on issue #23899: package 'pkg_resource' is deprecated in favor of importlib
Posted by "sebastianliebscher (via GitHub)" <gi...@apache.org>.
sebastianliebscher commented on issue #23899:
URL: https://github.com/apache/superset/issues/23899#issuecomment-1651708206
I think this issue is fixed when part 2 of https://github.com/apache/superset/pull/24578 gets merged @cwegener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] package 'pkg_resource' is deprecated in favor of importlib [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #23899:
URL: https://github.com/apache/superset/issues/23899#issuecomment-1983945390
We can slap a HOLD label on it, and line up the shot for an eventual 5.0 :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cwegener commented on issue #23899: package 'pkg_resource' is deprecated in favor of importlib
Posted by "cwegener (via GitHub)" <gi...@apache.org>.
cwegener commented on issue #23899:
URL: https://github.com/apache/superset/issues/23899#issuecomment-1652531745
I still have one last step to go before this is complete, which is to change the `UPLOAD_FOLDER` logic in `superset.config` which currently relies on said setuptools module.
The won't be any ceremonious removal of the setuptools runtime dependency from the requires list though, as that runtime dependency is not explicitly declared in the metadata at all anyway. But instead superset simply presumes that setuptools is a runtime dependency that is installed everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] package 'pkg_resource' is deprecated in favor of importlib [superset]
Posted by "cwegener (via GitHub)" <gi...@apache.org>.
cwegener commented on issue #23899:
URL: https://github.com/apache/superset/issues/23899#issuecomment-1984390348
> We can slap a HOLD label on it, and line up the shot for an eventual 5.0 :D
Sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] package 'pkg_resource' is deprecated in favor of importlib [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #23899:
URL: https://github.com/apache/superset/issues/23899#issuecomment-2596535074
Anyone have bandwidth to work on this? The breaking change window is open now and closes in a couple weeks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org