You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2008/11/20 18:29:15 UTC
[Bug 6020] New: RFE: add 'urinsrhsbl' rule type to URIDNSBL plugin
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
Summary: RFE: add 'urinsrhsbl' rule type to URIDNSBL plugin
Product: Spamassassin
Version: unspecified
Platform: Other
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P5
Component: Plugins
AssignedTo: dev@spamassassin.apache.org
ReportedBy: jm@jmason.org
Here's something that may be useful ;)
Perform a RHSBL-style domain lookup against the contents of the NS records
for each URI. In other words, a URI using the domain C<foo.com> will cause
an NS lookup to take place; assuming that domain has an NS of C<bar.com>,
that will cause a lookup of C<bar.com.uriblzone.net>.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] RFE: add 'urinsrhsbl' rule type to URIDNSBL plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4402 is|0 |1
obsolete| |
--- Comment #9 from Justin Mason <jm...@jmason.org> 2008-11-27 08:34:18 PST ---
Created an attachment (id=4404)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4404)
implementation for 3.2.x
and here's an implementation for 3.2.5 ;) includes that fix. It passes its
test, so _should_ be ok...
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] [review] RFE: add 'urinsrhsbl' rule type to URIDNSBL
plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
--- Comment #14 from Justin Mason <jm...@jmason.org> 2008-12-22 13:24:00 PST ---
Alex persuaded me to add this:
: 41...; svn commit -m "bug 6020: allow urifullnsrhsbl: variant of urinsrhsbl
which looks up the full hostname from the NS record in the DNSBL, not just the
domain" lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm t/uribl.t
Sending lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm
Sending t/uribl.t
Transmitting file data ..
Committed revision 728782 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=728782 ).
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] RFE: add 'urinsrhsbl' rule type to URIDNSBL plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
--- Comment #7 from AXB <al...@gmail.com> 2008-11-27 08:26:02 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > Requesting possible downport for SA 3.2.5 to be updated via
> > sa-update --allowplugins
>
> I can backport it to 3.2.5, but I doubt it'd be released in the rule update
> packages, so --allowplugins wouldn't install it; it'd have to wait for a 3.2.6
> release. (which IMO would be rare.)
>
works for me...
pls note in bug if there is need to update any other modules.
thanks a bunch
AXB
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] RFE: add 'urinsrhsbl' rule type to URIDNSBL plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
--- Comment #6 from Justin Mason <jm...@jmason.org> 2008-11-27 08:22:11 PST ---
(In reply to comment #5)
> Requesting possible downport for SA 3.2.5 to be updated via
> sa-update --allowplugins
I can backport it to 3.2.5, but I doubt it'd be released in the rule update
packages, so --allowplugins wouldn't install it; it'd have to wait for a 3.2.6
release. (which IMO would be rare.)
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] [review] RFE: add 'urinsrhsbl' rule type to URIDNSBL
plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |track@plectere.com
--- Comment #13 from Justin Mason <jm...@jmason.org> 2008-12-22 13:22:17 PST ---
*** Bug 4106 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] [review] RFE: add 'urinsrhsbl' rule type to URIDNSBL
plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
--- Comment #11 from AXB <al...@gmail.com> 2008-11-27 08:56:37 PST ---
(In reply to comment #9)
> Created an attachment (id=4404)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4404) [details]
> implementation for 3.2.x
>
> and here's an implementation for 3.2.5 ;) includes that fix. It passes its
> test, so _should_ be ok...
>
patched / installed ok
running and seeing hits on test zone.
thanks a lot.
AXB
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] [review] RFE: add 'urinsrhsbl' rule type to URIDNSBL
plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
Summary|RFE: add 'urinsrhsbl' rule |[review] RFE: add
|type to URIDNSBL plugin |'urinsrhsbl' rule type to
| |URIDNSBL plugin
Target Milestone|3.3.0 |3.2.6
--- Comment #10 from Justin Mason <jm...@jmason.org> 2008-11-27 08:34:58 PST ---
reopening for possible inclusion in 3.2.x
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] [review] RFE: add 'urinsrhsbl' rule type to URIDNSBL
plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
--- Comment #12 from Justin Mason <jm...@jmason.org> 2008-11-28 08:03:05 PST ---
oops, forgot to check in att 4403 ---
: 6...; svn commit -m "bug 6020: if no URIBLs are already defined, no NSRHSBL
lookup would happen. fix"
Sending lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm
Transmitting file data .
Committed revision 721524 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=721524 ).
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] [review] RFE: add 'urinsrhsbl' rule type to URIDNSBL
plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
--- Comment #17 from Mark Martinec <Ma...@ijs.si> 2011-05-23 18:22:10 UTC ---
Closing. These changes are in 3.3.0.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] [review] RFE: add 'urinsrhsbl' rule type to URIDNSBL
plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4404 is|0 |1
obsolete| |
--- Comment #15 from Justin Mason <jm...@jmason.org> 2008-12-22 13:28:41 PST ---
Created an attachment (id=4409)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4409)
new impl for 3.2.x
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] RFE: add 'urinsrhsbl' rule type to URIDNSBL plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
--- Comment #3 from Roger So <ro...@outblaze.com> 2008-11-25 19:30:55 PST ---
Created an attachment (id=4402)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4402)
alternative implementation, against 3.2.5
Oh, you beat me to it. I was going to polish it up before I send this out.
The main difference (apart from minimal documentation and no test case) is that
rather than using RegistrarBoundaries::trim_domain(), I am checking every level
of the returned NS against the list, which works slightly better for us.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] RFE: add 'urinsrhsbl' rule type to URIDNSBL plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
--- Comment #8 from Justin Mason <jm...@jmason.org> 2008-11-27 08:32:27 PST ---
Created an attachment (id=4403)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4403)
3.3.0 impl patch on top of 4395
oops. found a bug in the 3.3.0 code; if there were no URIBLs already defined
for the zone, the NS-RHSBL lookup would never happen.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] RFE: add 'urinsrhsbl' rule type to URIDNSBL plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
--- Comment #1 from Justin Mason <jm...@jmason.org> 2008-11-24 07:36:08 PST ---
Created an attachment (id=4395)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4395)
implementation for 3.3.0
AXB made me do it. Here's the implementation of that...
=item urinsrhsbl NAME_OF_RULE rhsbl_zone lookuptype
Perform a RHSBL-style domain lookup against the contents of the NS records
for each URI. In other words, a URI using the domain C<foo.com> will cause
an NS lookup to take place; assuming that domain has an NS of C<ns0.bar.com>,
that will cause a lookup of C<bar.com.uriblzone.net>. Note that hostnames
are stripped from both the domain used in the URI, and the domain in the
lookup.
C<NAME_OF_RULE> is the name of the rule to be used, C<rhsbl_zone> is the zone
to look up domain names in, and C<lookuptype> is the type of lookup (B<TXT>
or
B<A>).
Note that, as with C<urirhsbl>, you must also define a body-eval rule calling
C<check_uridnsbl()> to use this.
=item urinsrhssub NAME_OF_RULE rhsbl_zone lookuptype subtest
Specify a RHSBL-style domain-NS lookup, as above, with a sub-test.
C<NAME_OF_RULE> is the name of the rule to be used, C<rhsbl_zone> is the zone
to look up domain names in, and C<lookuptype> is the type of lookup (B<TXT>
or
B<A>). C<subtest> is the sub-test to run against the returned data; see
<urirhssub>.
Note that, as with C<urirhsbl>, you must also define a body-eval rule calling
C<check_uridnsbl()> to use this.
Checked into 3.3.0 trunk:
: 96...; svn commit -m "bug 6020: add 'urinsrhsbl' and 'urinsrhssub' rule types
to URIDNSBL plugin, allowing listing of NS record strings in URIBL blocklists"
Sending lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm
Sending t/data/spam/dnsbl.eml
Sending t/uribl.t
Transmitting file data ...
Committed revision 720211 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=720211 ).
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] RFE: add 'urinsrhsbl' rule type to URIDNSBL plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
--- Comment #4 from Justin Mason <jm...@jmason.org> 2008-11-26 02:00:06 PST ---
(In reply to comment #3)
> Created an attachment (id=4402)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4402) [details]
> alternative implementation, against 3.2.5
>
> Oh, you beat me to it. I was going to polish it up before I send this out.
heh, sorry about that ;)
> The main difference (apart from minimal documentation and no test case) is that
> rather than using RegistrarBoundaries::trim_domain(), I am checking every level
> of the returned NS against the list, which works slightly better for us.
If that's to catch bad subdomains on specific sites (like live.com for
example), I also added 'util_rb_3tld' recently in trunk which allows you to do:
util_rb_3tld spaces.live.com
in which case foo.spaces.live.com will be preserved in the lookups.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] [review] RFE: add 'urinsrhsbl' rule type to URIDNSBL
plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
--- Comment #18 from Mark Martinec <Ma...@ijs.si> 2011-05-23 18:22:52 UTC ---
Oops, closing now for real.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] [review] RFE: add 'urinsrhsbl' rule type to URIDNSBL
plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
Darxus <Da...@ChaosReigns.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Darxus@ChaosReigns.com
--- Comment #16 from Darxus <Da...@ChaosReigns.com> 2011-05-23 17:38:32 UTC ---
Close.
Committed to trunk before 3.3 was branched from trunk. Won't get backported to
3.2.
Last updated 2.4 years ago. I did read all comments.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] RFE: add 'urinsrhsbl' rule type to URIDNSBL plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #2 from Justin Mason <jm...@jmason.org> 2008-11-24 07:36:46 PST ---
implemented for 3.3.0: closing....
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6020] RFE: add 'urinsrhsbl' rule type to URIDNSBL plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6020
--- Comment #5 from AXB <al...@gmail.com> 2008-11-27 07:31:32 PST ---
Requesting possible downport for SA 3.2.5 to be updated via
sa-update --allowplugins
Thx
AXB
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.