[jira] [Commented] (S2GRAPH-43) Bug on offset when Interval is given on query.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153919#comment-15153919 ] 

ASF GitHub Bot commented on S2GRAPH-43:
---------------------------------------

GitHub user SteamShon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/26

    [S2GRAPH-43] Bug on offset when Interval is given on query.

    + add check for columnFilter on queryParam.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-43

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
    
----
commit 94ea6946b0c64929e6a2f8fda9a1e3b102e55ac7
Author: DO YUNG YOON <st...@apache.org>
Date:   2016-02-19T08:43:18Z

    S2GRAPH-43 Bug on offset when Interval is given on query.
    
    add check for columnFilter on queryParam.

----


> Bug on offset when Interval is given on query.
> ----------------------------------------------
>
>                 Key: S2GRAPH-43
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-43
>             Project: S2Graph
>          Issue Type: Bug
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>            Priority: Trivial
>              Labels: easyfix
>
> Since {{degreeEdge}} that store how many edges are exist from this source vertex use empty byte array as qualifier, it always comes at first. 
> Above is reason why we add 1 on limit when offset is 0(if offset is 0, then we need to return degree too so storage level limit should be increased by 1).
> This is not actually true when "interval" is given.
> When query has interval option, then it use columnRangeFilter, and with offset 0 and interval option, then current implementation return 1 more result. 
> I think adding 1 on provided limit should check if interval is specified on queryParam.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)