You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/09/15 16:44:08 UTC
[PR] fix(ui): space numbers from units in the zh turn duration [maka]
Astro-Han opened a new pull request, #5360:
URL: https://github.com/apache/maka/pull/5360
## Summary
The settled process summary in Chinese read `用时 35秒`, gluing the number to its unit, while other zh counts in the product separate them (`goalElapsed` uses `' 秒'`, counts use `} 个`). The zh and zh-TW `processDuration` templates now render `用时 3 分 33 秒`.
Retry delays keep their compact form (`45秒后重试`), which `conversation-copy.test.ts` pins deliberately.
## Verification
- `npm --workspace @maka/ui run build`, then `node --test` on `chat-turn-answer-identity.test.js` and `conversation-copy.test.js`: 34 pass.
- `npm run format`, `npm run lint`: clean.
- No light/dark comparison images: the change is two copy templates with no layout or color impact.
## AI use
Select exactly one:
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Claude Code diagnosed the copy template and wrote the change and test update.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(ui): space numbers from units in the zh turn duration [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han closed pull request #5360: fix(ui): space numbers from units in the zh turn duration
URL: https://github.com/apache/maka/pull/5360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(ui): space numbers from units in the zh turn duration [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on PR #5360:
URL: https://github.com/apache/maka/pull/5360#issuecomment-5684827208
Folded into the transcript per-event watermark PR, which also fixes the running-turn elapsed clock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org