You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2024/01/19 12:07:29 UTC
(kyuubi) branch master updated: [KYUUBI #5999] loads the interval of sessionConfCache from configurable file in FileSessionConfAdvisor
This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 5d7380058 [KYUUBI #5999] loads the interval of sessionConfCache from configurable file in FileSessionConfAdvisor
5d7380058 is described below
commit 5d738005868835982592f55f07f1bed29b81062e
Author: hezhao2 <he...@cisco.com>
AuthorDate: Fri Jan 19 20:07:21 2024 +0800
[KYUUBI #5999] loads the interval of sessionConfCache from configurable file in FileSessionConfAdvisor
# :mag: Description
## Issue References ๐
This pull request fixes the issue that FileSessionConfAdvisor failed to load the interval defined in configuration file.
## Describe Your Solution ๐ง
load the Kyuubi configuration from configurable file instead of using environment parameters.
## Types of changes :bookmark:
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Test Plan ๐งช
#### Behavior Without This Pull Request :coffin:
#### Behavior With This Pull Request :tada:
#### Related Unit Tests
---
# Checklist ๐
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
**Be nice. Be informative.**
Closes #5999 from zhaohehuhu/dev-0119.
Closes #5999
592d15acd [hezhao2] loads the interval of sessionConfCache from configurable file in FileSessionConfAdvisor
Authored-by: hezhao2 <he...@cisco.com>
Signed-off-by: Cheng Pan <ch...@apache.org>
---
.../main/scala/org/apache/kyuubi/session/FileSessionConfAdvisor.scala | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kyuubi-server/src/main/scala/org/apache/kyuubi/session/FileSessionConfAdvisor.scala b/kyuubi-server/src/main/scala/org/apache/kyuubi/session/FileSessionConfAdvisor.scala
index 96569bc38..d480520c4 100644
--- a/kyuubi-server/src/main/scala/org/apache/kyuubi/session/FileSessionConfAdvisor.scala
+++ b/kyuubi-server/src/main/scala/org/apache/kyuubi/session/FileSessionConfAdvisor.scala
@@ -43,7 +43,8 @@ class FileSessionConfAdvisor extends SessionConfAdvisor {
}
object FileSessionConfAdvisor extends Logging {
- private val reloadInterval: Long = KyuubiConf().get(KyuubiConf.SESSION_CONF_FILE_RELOAD_INTERVAL)
+ private val reloadInterval: Long =
+ KyuubiConf().loadFileDefaults().get(KyuubiConf.SESSION_CONF_FILE_RELOAD_INTERVAL)
private lazy val sessionConfCache: LoadingCache[String, JMap[String, String]] =
CacheBuilder.newBuilder()
.expireAfterWrite(