You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/05 19:23:31 UTC
[GitHub] [incubator-superset] nytai opened a new pull request #9247: [chart]
fix, datasource link in listview
nytai opened a new pull request #9247: [chart] fix, datasource link in listview
URL: https://github.com/apache/incubator-superset/pull/9247
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes the datasource url in the new react listview for charts
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@dpgaspar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9247: [chart]
fix, datasource link in listview
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9247: [chart] fix, datasource link in listview
URL: https://github.com/apache/incubator-superset/pull/9247#issuecomment-595473553
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9247?src=pr&el=h1) Report
> Merging [#9247](https://codecov.io/gh/apache/incubator-superset/pull/9247?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7d572d9e9621e6c469d6db0afe650e41fcf297b1?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9247?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9247 +/- ##
==========================================
- Coverage 58.93% 58.92% -0.01%
==========================================
Files 373 373
Lines 12014 12012 -2
Branches 2945 2945
==========================================
- Hits 7080 7078 -2
Misses 4755 4755
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9247?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9247/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `62.72% <100%> (-0.67%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9247?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9247?src=pr&el=footer). Last update [7d572d9...496b2e8](https://codecov.io/gh/apache/incubator-superset/pull/9247?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #9247:
[chart] fix, datasource link in listview
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #9247: [chart] fix, datasource link in listview
URL: https://github.com/apache/incubator-superset/pull/9247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org