Re: [PR] IGNITE-25695 SQL Calcite: Fix flaky TimeCalculationExecutionTest [ignite]

["Vladsz83 (via GitHub)" <gi...@apache.org>]

Vladsz83 commented on code in PR #12146:
URL: https://github.com/apache/ignite/pull/12146#discussion_r2201556634


##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/AbstractExecutionTest.java:
##########
@@ -210,7 +210,15 @@ public void setup() throws Exception {
                 taskExecutor = executor;
             }
             else {
-                taskExecutor = new QueryBlockingTaskExecutor(kernal);
+                taskExecutor = new QueryBlockingTaskExecutor(kernal) {

Review Comment:
   I think we should not affect the other tests. let's do something like:
   
   ```
       
   AbstractExecutionTest {
        /** */
       protected boolean delayedBlockingExecutor;
   }
   ```
   and
   ```
                   if (delayedBlockingExecutor) {
                       taskExecutor = new QueryBlockingTaskExecutor(kernal) {
                           @Override public void execute(UUID qryId, long fragmentId, Runnable qryTask) {
                               super.execute(qryId, fragmentId, () -> {
                                   qryTask.run();
   
                                   LockSupport.parkNanos(ThreadLocalRandom.current().nextLong(1_000, 10_000));
                               });
                           }
                       };
                   }
                   else
                       taskExecutor = new QueryBlockingTaskExecutor(kernal);
   ```
   and
   ```
   public class TimeCalculationExecutionTest extends AbstractExecutionTest {
       /** */
       @Override public void setup() throws Exception {
           delayedBlockingExecutor = true;
   
           super.setup();
       }
   }
   ```
   WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org