You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/03/31 20:42:50 UTC

[GitHub] [ignite] gvvinblade opened a new pull request #7598: IGNITE-12700: Calcite integration. Aggregates support.

gvvinblade opened a new pull request #7598: IGNITE-12700: Calcite integration. Aggregates support.
URL: https://github.com/apache/ignite/pull/7598
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] gvvinblade commented on a change in pull request #7598: IGNITE-12700: Calcite integration. Aggregates support.

Posted by GitBox <gi...@apache.org>.
gvvinblade commented on a change in pull request #7598: IGNITE-12700: Calcite integration. Aggregates support.
URL: https://github.com/apache/ignite/pull/7598#discussion_r404157214
 
 

 ##########
 File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/ExpressionFactory.java
 ##########
 @@ -65,12 +73,13 @@
  * Implements rex expression into a function object. Uses JaninoRexCompiler under the hood.
  * Each expression compiles into a class and a wrapper over it is returned.
  */
+@SuppressWarnings({"rawtypes"})
 public class ExpressionFactory {
     /** */
-    private static final Map<String, Scalar> CACHE_1 = new GridBoundedConcurrentLinkedHashMap<>(1024);
+    private static final Map<String, Scalar> SCALAR_CACHE = new GridBoundedConcurrentLinkedHashMap<>(1024);
 
     /** */
-    private static final Map<String, CallOperation> CACHE_2 = new GridBoundedConcurrentLinkedHashMap<>(1024);
+    private static final Map<String, CallOperation> CALL_CACHE = new GridBoundedConcurrentLinkedHashMap<>(1024);
 
 Review comment:
   changed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] gvvinblade closed pull request #7598: IGNITE-12700: Calcite integration. Aggregates support.

Posted by GitBox <gi...@apache.org>.
gvvinblade closed pull request #7598: IGNITE-12700: Calcite integration. Aggregates support.
URL: https://github.com/apache/ignite/pull/7598
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] AMashenkov commented on a change in pull request #7598: IGNITE-12700: Calcite integration. Aggregates support.

Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #7598: IGNITE-12700: Calcite integration. Aggregates support.
URL: https://github.com/apache/ignite/pull/7598#discussion_r401572994
 
 

 ##########
 File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/ExpressionFactory.java
 ##########
 @@ -65,12 +73,13 @@
  * Implements rex expression into a function object. Uses JaninoRexCompiler under the hood.
  * Each expression compiles into a class and a wrapper over it is returned.
  */
+@SuppressWarnings({"rawtypes"})
 public class ExpressionFactory {
     /** */
-    private static final Map<String, Scalar> CACHE_1 = new GridBoundedConcurrentLinkedHashMap<>(1024);
+    private static final Map<String, Scalar> SCALAR_CACHE = new GridBoundedConcurrentLinkedHashMap<>(1024);
 
     /** */
-    private static final Map<String, CallOperation> CACHE_2 = new GridBoundedConcurrentLinkedHashMap<>(1024);
+    private static final Map<String, CallOperation> CALL_CACHE = new GridBoundedConcurrentLinkedHashMap<>(1024);
 
 Review comment:
   Will CALL_OP_CACHE be a better name?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services