You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2007/10/24 01:08:54 UTC
svn commit: r587689 -
/jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java
Author: sebb
Date: Tue Oct 23 16:08:53 2007
New Revision: 587689
URL: http://svn.apache.org/viewvc?rev=587689&view=rev
Log:
Use getResponseDataAsString() instead of doing own conversion
Modified:
jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java
Modified: jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java?rev=587689&r1=587688&r2=587689&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java (original)
+++ jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java Tue Oct 23 16:08:53 2007
@@ -611,28 +611,22 @@
private static String getResponseAsString(SampleResult res) {
- byte[] responseBytes = res.getResponseData();
String response = null;
if ((SampleResult.TEXT).equals(res.getDataType())) {
- try {
- // Showing large strings can be VERY costly, so we will avoid
- // doing so if the response
- // data is larger than 200K. TODO: instead, we could delay doing
- // the result.setText
- // call until the user chooses the "Response data" tab. Plus we
- // could warn the user
- // if this happens and revert the choice if he doesn't confirm
- // he's ready to wait.
- if (responseBytes.length > 200 * 1024) {
- response = ("Response too large to be displayed (" + responseBytes.length + " bytes).");
- log.warn("Response too large to display.");
- } else {
- response = new String(responseBytes, res.getDataEncoding());
- }
- } catch (UnsupportedEncodingException err) {
- log.warn("Could not decode response " + err);
- response = new String(responseBytes);// Try the default
- // encoding instead
+ // Showing large strings can be VERY costly, so we will avoid
+ // doing so if the response
+ // data is larger than 200K. TODO: instead, we could delay doing
+ // the result.setText
+ // call until the user chooses the "Response data" tab. Plus we
+ // could warn the user
+ // if this happens and revert the choice if he doesn't confirm
+ // he's ready to wait.
+ int len = res.getResponseData().length;
+ if (len > 200 * 1024) {
+ response = "Response too large to be displayed (" + len + " bytes).";
+ log.warn(response);
+ } else {
+ response = res.getResponseDataAsString();
}
}
return response;
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org