You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2011/01/24 21:38:45 UTC

[jira] Updated: (LUCENE-1574) PooledSegmentReader, pools SegmentReader underlying byte arrays

     [ https://issues.apache.org/jira/browse/LUCENE-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-1574:
---------------------------------------

    Attachment: LUCENE-1574.patch

Attached rough patch.

At least one test fails....

And, I haven't yet seen that this is in fact worthwhile.  The rough benchmark I have (which hits other issues so the results aren't conclusive yet) doesn't show much difference w/ this patch.  I think this patch may only be worthwhile at insane reopen rates, which I think in practice is rarely a legitimate use case (even though many apps start off thinking it is).

> PooledSegmentReader, pools SegmentReader underlying byte arrays
> ---------------------------------------------------------------
>
>                 Key: LUCENE-1574
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1574
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.4.1
>            Reporter: Jason Rutherglen
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-1574.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> PooledSegmentReader pools the underlying byte arrays of deleted docs and norms for realtime search.  It is designed for use with IndexReader.clone which can create many copies of byte arrays, which are of the same length for a given segment.  When pooled they can be reused which could save on memory.  
> Do we want to benchmark the memory usage comparison of PooledSegmentReader vs GC?  Many times GC is enough for these smaller objects.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org