You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/10/12 13:35:50 UTC
[PR] [SPARK-45521][ML] Avoid re-computation of nnz in `VectorAssembler` [spark]
zhengruifeng opened a new pull request, #43353:
URL: https://github.com/apache/spark/pull/43353
### What changes were proposed in this pull request?
1, add a new private `compressed` method with given `nnz`, since we can know it sometime;
2, minor change `Array.range(0, length)` -> `Iterator.range(0, length)` to avoid array creation;
### Why are the changes needed?
in `VectorAssembler`, the `nnz` if already known before vector construction, the scan to compute nnz can be skipped;
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45521][ML] Avoid re-computation of nnz in `VectorAssembler` [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43353:
URL: https://github.com/apache/spark/pull/43353#issuecomment-1760590241
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45521][ML] Avoid re-computation of nnz in `VectorAssembler` [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #43353: [SPARK-45521][ML] Avoid re-computation of nnz in `VectorAssembler`
URL: https://github.com/apache/spark/pull/43353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org